jmc
jmc copied to clipboard
openjdk
7992: Add API to easily write annotated Java JFR events
This PR extends the JFR Writer API with the ability to use the custom JFR event types (eg. classes extending jdk.jfr.Event) and register new writer type for them and also directly accept the instances of those types to write them in the recording.
Progress
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)
Issue
- JMC-7992: Add API to easily write annotated Java JFR events (Enhancement - P3)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/457/head:pull/457
$ git checkout pull/457
Update a local copy of the PR:
$ git checkout pull/457
$ git pull https://git.openjdk.org/jmc.git pull/457/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 457
View PR using the GUI difftool:
$ git pr show -t 457
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/457.diff
Webrev
:wave: Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@jbachorik This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Webrevs
- 03: Full - Incremental (8b50e795)
- 02: Full - Incremental (5bd8c044)
- 01: Full - Incremental (e4e6c7cf)
- 00: Full (eecdda83)
@jbachorik Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@jbachorik This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
7992: Add API to easily write annotated Java JFR events
Reviewed-by: hirt
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@jbachorik Unknown command rebase - for a list of valid commands use /help.
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Hi @jbachorik! Some tests verifying the registering of some subclass of jdk.jfr.Event, and that also have annotations in it, and that creates a few events of it, would be good.
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@thegreystone Yes, I have extended the RecordingImplTest to cover also the new API addition.
@jbachorik Your change (at version 8b50e795a16b19db64ddf3eaa6b3ed1983e484cc) is now ready to be sponsored by a Committer.
@jbachorik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Going to push as commit 4c9d9e47bcf13d6c12ddfcdeddb2e90dbe3b691b.
Since your change was applied there have been 2 commits pushed to the master branch:
- 5016cc1919616f559cec95a20dc3ae2edb721dc3: 8245: Improve XML processing
- 8a04432f1678a2a9119becd509100417b27b56eb: 8236: Add support for Jolokia discovery
Your commit was automatically rebased without conflicts.
@thegreystone @jbachorik Pushed as commit 4c9d9e47bcf13d6c12ddfcdeddb2e90dbe3b691b.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.