jmc icon indicating copy to clipboard operation
jmc copied to clipboard

Bump the runtime to Java11

Open bric3 opened this issue 3 years ago • 4 comments

This is a work-in-progress to define the java runtime to Java 11.

Once #361 is merged, it will be possible to move JMC RCP and plugin to Java 11.

The core libraries target however remains Java 1.8.


Progress

  • [ ] Commit message must refer to an issue
  • [ ] Change must be properly reviewed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/359/head:pull/359
$ git checkout pull/359

Update a local copy of the PR:
$ git checkout pull/359
$ git pull https://git.openjdk.java.net/jmc pull/359/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 359

View PR using the GUI difftool:
$ git pr show -t 359

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/359.diff

bric3 avatar Jan 14 '22 14:01 bric3

:wave: Welcome back bric3! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jan 14 '22 14:01 bridgekeeper[bot]

The core libraries target however remains Java 1.8.

Why? This seems to prevent us from running on Java 17.

parttimenerd avatar Jan 20 '22 12:01 parttimenerd

The core libraries are shipped to maven central, and can be consumed by projects running Java 1.8.

cc @thegreystone

bric3 avatar Jan 20 '22 14:01 bric3

Ok, I was probably wrong.

parttimenerd avatar Jan 20 '22 14:01 parttimenerd

@bric3 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout bump-to-java11
git fetch https://git.openjdk.org/jmc master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk[bot] avatar Feb 17 '23 18:02 openjdk[bot]

Superseded by #482

bric3 avatar May 16 '23 10:05 bric3