jmc icon indicating copy to clipboard operation
jmc copied to clipboard

7074: Smart pruning of graphs to make it possible to sensibly render larger graphs

Open jpbempel opened this issue 3 years ago • 2 comments


Progress

  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed

Issue

  • JMC-7074: Smart pruning of graphs to make it possible to sensibly render larger graphs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/349/head:pull/349
$ git checkout pull/349

Update a local copy of the PR:
$ git checkout pull/349
$ git pull https://git.openjdk.java.net/jmc pull/349/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 349

View PR using the GUI difftool:
$ git pr show -t 349

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/349.diff

jpbempel avatar Jan 11 '22 17:01 jpbempel

:wave: Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jan 11 '22 17:01 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Apr 15 '22 21:04 mlbridge[bot]

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7074: Smart pruning of graphs to make it possible to sensibly render larger graphs

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 9a46d3ec54e80d310b27b73ceb4c84deda9ead47: 6757: Selector for attribute in the flame graph
  • c03822bdc231003d30b7f7df42ca44b2ae6cd78f: 7096: Bring back Object statistics table for heap.
  • f573b72d7a4d9d4bd8b57b77554caf10a36423a8: 7874: Update thirdpartyreadme.txt file for upgraded third party libraries
  • 195d32c00510f28b77756a7f262af5877d371606: 7872: Adding artifacts to third-party pom file, which are not getting resolved by maven
  • b9d1f1e65a5f53489c4bbfa410d2b7cea288ccaa: 7831: Add new view for hierarchical edge bundling
  • 266643e4f305ce1ce7fc981cd3f1998119f47455: 7820: Add validations for master password
  • eabb8615a3f73360626374748b36324f77a6cef3: 7862: Platform-definitions-2022-06.target file has space in pde version
  • 591d7b6b8e291d57426aed80715c743bf947cddc: 7860: Upgrade d3-flame-graph in github to 4.1.3
  • 7606e1c4fdbe9a3f1745ef4d2b5f8403e25484af: 7858: Upgrade jetty.project in github to 10.0.11
  • e65b5fe601fab4b8417ed23b28971d7061dc5aab: 7243: Resolve discrepancy between JDK attributes coming from different JDK versions
  • ... and 12 more: https://git.openjdk.org/jmc/compare/ee50a2000c408378329a8a1a5628a7250db13a89...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Sep 15 '22 20:09 openjdk[bot]

/integrate

jpbempel avatar Sep 16 '22 06:09 jpbempel

Going to push as commit b29aefc2fc59f8fe00d750fb0f0681c351b49ae1. Since your change was applied there have been 22 commits pushed to the master branch:

  • 9a46d3ec54e80d310b27b73ceb4c84deda9ead47: 6757: Selector for attribute in the flame graph
  • c03822bdc231003d30b7f7df42ca44b2ae6cd78f: 7096: Bring back Object statistics table for heap.
  • f573b72d7a4d9d4bd8b57b77554caf10a36423a8: 7874: Update thirdpartyreadme.txt file for upgraded third party libraries
  • 195d32c00510f28b77756a7f262af5877d371606: 7872: Adding artifacts to third-party pom file, which are not getting resolved by maven
  • b9d1f1e65a5f53489c4bbfa410d2b7cea288ccaa: 7831: Add new view for hierarchical edge bundling
  • 266643e4f305ce1ce7fc981cd3f1998119f47455: 7820: Add validations for master password
  • eabb8615a3f73360626374748b36324f77a6cef3: 7862: Platform-definitions-2022-06.target file has space in pde version
  • 591d7b6b8e291d57426aed80715c743bf947cddc: 7860: Upgrade d3-flame-graph in github to 4.1.3
  • 7606e1c4fdbe9a3f1745ef4d2b5f8403e25484af: 7858: Upgrade jetty.project in github to 10.0.11
  • e65b5fe601fab4b8417ed23b28971d7061dc5aab: 7243: Resolve discrepancy between JDK attributes coming from different JDK versions
  • ... and 12 more: https://git.openjdk.org/jmc/compare/ee50a2000c408378329a8a1a5628a7250db13a89...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Sep 16 '22 06:09 openjdk[bot]

@jpbempel Pushed as commit b29aefc2fc59f8fe00d750fb0f0681c351b49ae1.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Sep 16 '22 06:09 openjdk[bot]