jfx icon indicating copy to clipboard operation
jfx copied to clipboard
verified publisher icon openjdk

8279514: NPE on clearing value of IntegerSpinnerValueFactory

Open aghaisas opened this issue 3 years ago • 2 comments

A null check has been added to below SpinnerValueFactory classes in valueProperty() ChangeListeners-

  • IntegerSpinnerValueFactory
  • LocalDateSpinnerValueFactory
  • LocalTimeSpinnerValueFactory
  • ListSpinnerValueFactory

Added 5 tests that detect NPE for above 4 Spinner factories. Only DoubleSpinnerValueFactory already had a valid null check - so the test for it passes before and after.

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8279514: NPE on clearing value of IntegerSpinnerValueFactory

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/865/head:pull/865
$ git checkout pull/865

Update a local copy of the PR:
$ git checkout pull/865
$ git pull https://git.openjdk.org/jfx pull/865/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 865

View PR using the GUI difftool:
$ git pr show -t 865

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/865.diff

aghaisas avatar Aug 10 '22 06:08 aghaisas

:wave: Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 10 '22 06:08 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Aug 10 '22 07:08 mlbridge[bot]

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279514: NPE on clearing value of IntegerSpinnerValueFactory

Reviewed-by: mhanl, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • eb8f2fe3c97398b202ad8241e6df647dc817636e: 8292678: Openjfx: all projects to use JUnit5 (Eclipse)
  • f71984938c686e52d61fd9c8470df4b453a253b6: 8290841: Notify menu event after a long press gesture on Android is not dispatched
  • ae9928bc4002122a9fb70e9d49ffe9be0cff1a11: 8287604: Update MarlinFX to 0.9.4.6
  • da580ba4a7e743e2a49f5a2c7f3b40fa01a4438a: 8292609: Cherry-pick WebKit 614.1 stabilization fixes
  • 996eb84b9df484fc78527ded311e7aa06aec56da: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char
  • f95f09f5af561e3a6f3804a4f54aff83e9d2bb0b: 8289542: Update JPEG Image Decoding Software to 9e
  • 6d6726c3d69379559c4d66681726adc4e794899c: Merge
  • 8b96776510908c14a860680ad99404c339faa48f: 8286678: Fix mistakes in FX API docs
  • 5c00783352940b08f6254d2250524ef804984267: 8291906: Bindings.createXxxBinding inherit incorrect method docs
  • 7cb8d679dc2aa96b7c9a2bd60983ab74aa275967: 8235491: Tree/TableView: implementation of isSelected(int) violates contract
  • ... and 10 more: https://git.openjdk.org/jfx/compare/38324a70c3054e75cb22865e7ffcc5375b62939d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Sep 01 '22 22:09 openjdk[bot]

/integrate

aghaisas avatar Sep 02 '22 03:09 aghaisas

Going to push as commit d1a7ebdc3374066f1c1f2739551185cbb34bdf96. Since your change was applied there have been 20 commits pushed to the master branch:

  • eb8f2fe3c97398b202ad8241e6df647dc817636e: 8292678: Openjfx: all projects to use JUnit5 (Eclipse)
  • f71984938c686e52d61fd9c8470df4b453a253b6: 8290841: Notify menu event after a long press gesture on Android is not dispatched
  • ae9928bc4002122a9fb70e9d49ffe9be0cff1a11: 8287604: Update MarlinFX to 0.9.4.6
  • da580ba4a7e743e2a49f5a2c7f3b40fa01a4438a: 8292609: Cherry-pick WebKit 614.1 stabilization fixes
  • 996eb84b9df484fc78527ded311e7aa06aec56da: 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea & TextField when deleted last char
  • f95f09f5af561e3a6f3804a4f54aff83e9d2bb0b: 8289542: Update JPEG Image Decoding Software to 9e
  • 6d6726c3d69379559c4d66681726adc4e794899c: Merge
  • 8b96776510908c14a860680ad99404c339faa48f: 8286678: Fix mistakes in FX API docs
  • 5c00783352940b08f6254d2250524ef804984267: 8291906: Bindings.createXxxBinding inherit incorrect method docs
  • 7cb8d679dc2aa96b7c9a2bd60983ab74aa275967: 8235491: Tree/TableView: implementation of isSelected(int) violates contract
  • ... and 10 more: https://git.openjdk.org/jfx/compare/38324a70c3054e75cb22865e7ffcc5375b62939d...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Sep 02 '22 03:09 openjdk[bot]

@aghaisas Pushed as commit d1a7ebdc3374066f1c1f2739551185cbb34bdf96.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Sep 02 '22 03:09 openjdk[bot]