8271395: Fixing crash at printing

[FlorianKirmaier]

This PR switches the Thread to the QuantumRenderer, in the case the Disposer is called from another Thread - the printing Thread. I'm open for better solutions on how to fix this Issue. Initially i thought there is also a Race Condition in the resource pool, but a new one is created for the Printing Thread.

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8271395

Issue

• JDK-8271395: Crash during printing when disposing textures ⚠️ Title mismatch between PR and JBS.

Reviewers

• Phil Race (@prrace - Reviewer) 🔄 Re-review required (review applies to 0dc9ce1d)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx pull/618/head:pull/618
$ git checkout pull/618

Update a local copy of the PR:
$ git checkout pull/618
$ git pull https://git.openjdk.org/jfx pull/618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 618

View PR using the GUI difftool:
$ git pr show -t 618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/618.diff

[bridgekeeper[bot]]

:wave: Welcome back fkirmaier! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge[bot]]

Webrevs

• 03: Full - Incremental (27bf8836)
• 02: Full - Incremental (a41f41dd)
• 01: Full - Incremental (0dc9ce1d)
• 00: Full (72f9f9f1)

[kevinrushforth]

/reviewers 2

[openjdk[bot]]

@kevinrushforth The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[christianheilmann]

How to proceed to get this PR reviewed?

[FlorianKirmaier]

I've worked in the feedback, thank you @kevinrushforth Small note, this change is not used for a while and is therefore well tested.

[kevinrushforth]

@FlorianKirmaier This PR is pending the following:

1. Merge upstream master into your PR branch (so we can get a clean test run on the latest + your changes)
2. Change this PR title to 8271395: Crash during printing when disposing textures

[FlorianKirmaier]

@kevinrushforth I've just seen your comments. I've just merged it and changed the title!

[FlorianKirmaier]

The Mac build seems to be failing for some reason, unrelated to the PR.

[kevinrushforth]

Yes, that is due to JDK-8292549 which is fixed by the soon-to-be-integrated PR #879

[openjdk[bot]]

@FlorianKirmaier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271395: Crash during printing when disposing textures

Reviewed-by: kcr, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• cedc17cc26bb0ad3e2d0693bd174f118ad5f0b82: 8292549: GitHub actions: intermittent build failure on macOS while downloading ant

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[FlorianKirmaier]

/integrate

[openjdk[bot]]

@FlorianKirmaier Your change (at version 27bf8836a15fba77a15017e3824567157aedd898) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk[bot]]

Going to push as commit 88159811239b76399b8f90c6c648293b4a06528c. Since your change was applied there has been 1 commit pushed to the master branch:

• cedc17cc26bb0ad3e2d0693bd174f118ad5f0b82: 8292549: GitHub actions: intermittent build failure on macOS while downloading ant

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@kevinrushforth @FlorianKirmaier Pushed as commit 88159811239b76399b8f90c6c648293b4a06528c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.