jfx icon indicating copy to clipboard operation
jfx copied to clipboard

8269593: Different fontname on macos

Open johanvos opened this issue 3 years ago • 3 comments

Make sure the returned fullName of a created font matches the requested name. Since the name is used as a key/identifier in some cases, some internal code relies on this. Added a test to check the case of "System Font Regular" on MacOS, which fails before and succeeds after the patch.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/553/head:pull/553
$ git checkout pull/553

Update a local copy of the PR:
$ git checkout pull/553
$ git pull https://git.openjdk.java.net/jfx pull/553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 553

View PR using the GUI difftool:
$ git pr show -t 553

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/553.diff

johanvos avatar Jun 29 '21 14:06 johanvos

:wave: Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 29 '21 14:06 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Jun 29 '21 14:06 mlbridge[bot]

@prrace can you review this?

kevinrushforth avatar Jun 29 '21 17:06 kevinrushforth

@johanvos This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 31 '23 23:03 bridgekeeper[bot]

I am closing this PR now that #1067 is integrated.

kevinrushforth avatar Apr 11 '23 11:04 kevinrushforth