jfx
jfx copied to clipboard
8356042: RichTextArea: tab stops attributes
- adds tab stops paragraph attributes to the
RichTextArea - adds a ruler to the
RichEditorDemoAppexample
NOTE: This PR requires changes in #1813 (JDK-8357393) to be integrated first.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8356042: RichTextArea: tab stops attributes (Enhancement - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1800/head:pull/1800
$ git checkout pull/1800
Update a local copy of the PR:
$ git checkout pull/1800
$ git pull https://git.openjdk.org/jfx.git pull/1800/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1800
View PR using the GUI difftool:
$ git pr show -t 1800
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1800.diff
:wave: Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).
@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/touch
@andy-goryachev-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.
@andy-goryachev-oracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:
git checkout 8356042.ruler
git fetch https://git.openjdk.org/jfx.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/touch
@andy-goryachev-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.
@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/touch
@andy-goryachev-oracle The pull request is being re-evaluated and the inactivity timeout has been reset.