Prevent NPE when passing stage without scene to Dialog.initOwner

[Eng-Fouad]

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [ ] Commit message must refer to an issue

Errors

 ⚠️ OCA signatory status must be verified  ⚠️ The pull request body must not be empty.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1606/head:pull/1606
$ git checkout pull/1606

Update a local copy of the PR:
$ git checkout pull/1606
$ git pull https://git.openjdk.org/jfx.git pull/1606/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1606

View PR using the GUI difftool:
$ git pr show -t 1606

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1606.diff

[bridgekeeper[bot]]

Hi @Eng-Fouad, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Eng-Fouad" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[Eng-Fouad]

/signed

[bridgekeeper[bot]]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[bridgekeeper[bot]]

@Eng-Fouad This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[Maran23]

Hi, thanks for opening this PR. This is a NPE I also found recently. I can create a ticket for you, you then need to change the title to match the ticket.

But you also need to write a test. Since this NPE seems easy to provoke, it should be relatively straightforward to write one.

[Eng-Fouad]

Hi, thanks for opening this PR. This is a NPE I also found recently. I can create a ticket for you, you then need to change the title to match the ticket.

But you also need to write a test. Since this NPE seems easy to provoke, it should be relatively straightforward to write one.

Yes please, create a ticket and help me on how to write a test.

[bridgekeeper[bot]]

@Eng-Fouad This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[Maran23]

Check out: modules/javafx.controls/src/test/java/test/javafx/scene/control/DialogTest.java.

[bridgekeeper[bot]]

@Eng-Fouad This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@Eng-Fouad This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.