jfx icon indicating copy to clipboard operation
jfx copied to clipboard

8331748: Update libxml2 to 2.12.6

Open HimaBinduMeda opened this issue 1 year ago • 6 comments

Updated libxml to v2.12.6. Verified build and sanity testing on all platforms. No issue seen


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1453/head:pull/1453
$ git checkout pull/1453

Update a local copy of the PR:
$ git checkout pull/1453
$ git pull https://git.openjdk.org/jfx.git pull/1453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1453

View PR using the GUI difftool:
$ git pr show -t 1453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1453.diff

Webrev

Link to Webrev Comment

HimaBinduMeda avatar May 14 '24 05:05 HimaBinduMeda

:wave: Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 14 '24 05:05 bridgekeeper[bot]

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331748: Update libxml2 to 2.12.6

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • b86e6771b906bdf7ed517eb2d5ab76a2e92c1282: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming
  • eb6d55f7f067469e89402da2bfa46e1ecf11ea02: 8328603: HLS video stream fails to render consistently
  • 7699c448bbdfe4213f74eb47409d9c42b16b59a4: 8092102: Labeled: textTruncated property
  • d3da033a2dd5c287733545935242a8d1f71c0554: 8330462: StringIndexOutOfBoundException when typing anything into TextField
  • 35880cec5a998598c64eecbc7b3ae56b6ee3a6d8: 8331616: ChangeListener is not triggered when the InvalidationListener is removed
  • 36e65e8b5ef12c6c3eef406d035a985a50000e0a: 8331214: Doc: update spec for SpinnerFactory classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 14 '24 05:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 14 '24 05:05 mlbridge[bot]

@tiainen can you do a build/review?

johanvos avatar May 14 '24 06:05 johanvos

Reviewers: @tiainen @kevinrushforth

/reviewers 2

kevinrushforth avatar May 14 '24 13:05 kevinrushforth

@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

openjdk[bot] avatar May 14 '24 13:05 openjdk[bot]

/integrate

HimaBinduMeda avatar May 15 '24 15:05 HimaBinduMeda

Going to push as commit 97b1402501983f121f75c24a510f466837fa2ecc. Since your change was applied there have been 7 commits pushed to the master branch:

  • 581e3a70a45a550a97e391e06735f4837336ada8: 8329011: Update SQLite to 3.45.3
  • b86e6771b906bdf7ed517eb2d5ab76a2e92c1282: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming
  • eb6d55f7f067469e89402da2bfa46e1ecf11ea02: 8328603: HLS video stream fails to render consistently
  • 7699c448bbdfe4213f74eb47409d9c42b16b59a4: 8092102: Labeled: textTruncated property
  • d3da033a2dd5c287733545935242a8d1f71c0554: 8330462: StringIndexOutOfBoundException when typing anything into TextField
  • 35880cec5a998598c64eecbc7b3ae56b6ee3a6d8: 8331616: ChangeListener is not triggered when the InvalidationListener is removed
  • 36e65e8b5ef12c6c3eef406d035a985a50000e0a: 8331214: Doc: update spec for SpinnerFactory classes

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 15 '24 15:05 openjdk[bot]

@HimaBinduMeda Pushed as commit 97b1402501983f121f75c24a510f466837fa2ecc.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 15 '24 15:05 openjdk[bot]