8314968: Public InputMap

[andy-goryachev-oracle]

Summary:

• public InputMap, KeyBinding, BehaviorBase in javafx.scene.control.behavior package
• InputMap allows for adding key mappings on control (user-defined) and behavior (defined by the skin) levels
• two stage mapping: key binding -> function tag -> function; enables a wide range of control customization (in some cases even without subclassing behavior classes)

For more detailed introduction, see https://gist.github.com/andy-goryachev-oracle/294d8e4b3094fe16f8d55f6dd8b21c09

A number of Controls has been converted to use the new InputMap implementation:

• ColorPicker
• ComboBox
• DatePicker
• PasswordField
• TextArea
• TextField

This PR requires https://github.com/openjdk/jfx/pull/1221 to go in first.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8314968: Public InputMap (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1254/head:pull/1254
$ git checkout pull/1254

Update a local copy of the PR:
$ git checkout pull/1254
$ git pull https://git.openjdk.org/jfx.git pull/1254/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1254

View PR using the GUI difftool:
$ git pr show -t 1254

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1254.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[mlbridge[bot]]

Webrevs

• 02: Full (d45eadad)
• 01: Full (d8a80596)
• 00: Full (9df9b60f)

[satsen]

This is great, I once had to implement selection logic for normal labels (I never actually finished all the cases because it was just too hard with all the private API) and this would have been helpful to have.

[bridgekeeper[bot]]

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

@andy-goryachev-oracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8314968.input.map
git fetch https://git.openjdk.org/jfx.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[andy-goryachev-oracle]

Closing this pull request in favor of the updated one. Many thanks to everyone who provided the feedback!