jextract
jextract copied to clipboard
openjdk
Typo in word directory
This commit just fix a typo in the word directory.
Please add the following to the description of the pull request:
- A brief recap of the status quo, as it relates to the subject of the pull request.
- A description of why the status quo is problematic.
- A description of how this pull request addresses this issue.
- If you ran into issues while making changes in the code that you had to work around, please mention these as well, as this helps reviewers understand the changes that have been made.
For 1 and 2 it is also okay to refer to the JBS ticket, if that already contains a comprehensive problem description.
Please test your pull request before submitting it by running ./gradlew jtreg. If you're
not able to test locally on your machine, please indicate this in the pull request description,
and indicate which testing has been done instead (or indicate that no testing has been done).
It is possible to run tests through Github actions if you enable them for your fork (this is free). Github actions can be enabled for your fork from the 'Actions' tab. The tests will then run automatically after the pull request has been created.
Progress
- [x] Change must not contain extraneous whitespace
- [x] Change must be properly reviewed (no review required)
Reviewers
- Maurizio Cimadamore (@mcimadamore - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/240/head:pull/240
$ git checkout pull/240
Update a local copy of the PR:
$ git checkout pull/240
$ git pull https://git.openjdk.org/jextract.git pull/240/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 240
View PR using the GUI difftool:
$ git pr show -t 240
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/240.diff
Webrev
Hi @BrayanMnz, welcome to this OpenJDK project and thanks for contributing!
We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.
If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user BrayanMnz" as summary for the issue.
If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@BrayanMnz This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
Typo in word directory
Reviewed-by: mcimadamore
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 6 new commits pushed to the master branch:
- a699148238fad919390d67eeb73805e780a518e8: 7903727: Remove the reliance on String Templates feature
- d87ddec91bd5aceaa3882f3bd6d75b18d77e9842: Update macOS version of the OpenGL sample to match the current state of OpenGL/Glut on Mac
- 926070f9eea83a0cee916240052bf04d5f2312a6: Add support for bin folder in makefile
- 2fb93f965a3dc8ec8290a89527e9fa21c5907dd5: Remove duplicate copies of libclang on Linux
- 87a9efd4dfccd2196adb165f8bcf89cf9abfd0b1: 7903723: Jextract binary should live in a bin folder
- b4da3284d41863af47d4a36b5829849b27cd47f4: 7903720: Change layout of jextract image
Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mcimadamore) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!
:warning: @BrayanMnz the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:
$ git checkout patch-1
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push
@BrayanMnz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@BrayanMnz Your change (at version 7e6231a6496d49a5bd402a9e8c195a3e819d31e8) is now ready to be sponsored by a Committer.
Going to push as commit 5375adf4094a0ba8b29bb53d374f2c396e739734.
Since your change was applied there have been 6 commits pushed to the master branch:
- a699148238fad919390d67eeb73805e780a518e8: 7903727: Remove the reliance on String Templates feature
- d87ddec91bd5aceaa3882f3bd6d75b18d77e9842: Update macOS version of the OpenGL sample to match the current state of OpenGL/Glut on Mac
- 926070f9eea83a0cee916240052bf04d5f2312a6: Add support for bin folder in makefile
- 2fb93f965a3dc8ec8290a89527e9fa21c5907dd5: Remove duplicate copies of libclang on Linux
- 87a9efd4dfccd2196adb165f8bcf89cf9abfd0b1: 7903723: Jextract binary should live in a bin folder
- b4da3284d41863af47d4a36b5829849b27cd47f4: 7903720: Change layout of jextract image
Your commit was automatically rebased without conflicts.
@JornVernee @BrayanMnz Pushed as commit 5375adf4094a0ba8b29bb53d374f2c396e739734.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.