jdk8u icon indicating copy to clipboard operation
jdk8u copied to clipboard

8331791: [8u] AIX build break from JDK-8320005 backport

Open suchismith1993 opened this issue 9 months ago • 6 comments

https://github.com/openjdk/jdk8u/commit/c1c8064ef0f67e85cb6a28990f4784271d949a08 introduces a new call to the macro FREE_C_HEAP_ARRAY but is not using the correct number of arguments. jdk8u FREE_C_HEAP_ARRAY takes 3 arguments JBS-ISSUE: JDK-8331791


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8331791 needs maintainer approval

Issue

  • JDK-8331791: [8u] AIX build break from JDK-8320005 backport (Bug - P1)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/55/head:pull/55
$ git checkout pull/55

Update a local copy of the PR:
$ git checkout pull/55
$ git pull https://git.openjdk.org/jdk8u.git pull/55/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 55

View PR using the GUI difftool:
$ git pr show -t 55

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/55.diff

Webrev

Link to Webrev Comment

suchismith1993 avatar May 07 '24 17:05 suchismith1993

:wave: Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 07 '24 17:05 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar May 07 '24 17:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 07 '24 17:05 mlbridge[bot]

@jerboaa I have pushed the fix. However i am not sure why this was not caught by the pre-submit tests before.

suchismith1993 avatar May 07 '24 17:05 suchismith1993

@jerboaa I have pushed the fix. However i am not sure why this was not caught by the pre-submit tests before.

GHA doesn't run AIX builds. You need to check those OS/arch combinations yourself.

jerboaa avatar May 07 '24 18:05 jerboaa

This is the wrong repo. Please open the PR on jdk8u-dev.

jerboaa avatar May 07 '24 18:05 jerboaa