jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

fix: unnecessary logical conditions

Open tobemonkey opened this issue 1 year ago • 6 comments

Alright, I know this small change might seem insignificant, but after thinking it over, I’ve decided to submit my code and hope it gets accepted


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [ ] Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/579/head:pull/579
$ git checkout pull/579

Update a local copy of the PR:
$ git checkout pull/579
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 579

View PR using the GUI difftool:
$ git pr show -t 579

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/579.diff

tobemonkey avatar Sep 14 '24 09:09 tobemonkey

Hi @tobemonkey, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tobemonkey" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

bridgekeeper[bot] avatar Sep 14 '24 09:09 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Sep 14 '24 09:09 openjdk[bot]

:warning: @tobemonkey a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master b7348860e89a8aa4466caf7eea1fe628f5b8942a
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

openjdk[bot] avatar Sep 14 '24 09:09 openjdk[bot]

/signed

tobemonkey avatar Sep 14 '24 09:09 tobemonkey

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

bridgekeeper[bot] avatar Sep 14 '24 09:09 bridgekeeper[bot]

Hi, please send me an e-mail at [email protected] so that I can verify your account.

robilad avatar Sep 18 '24 20:09 robilad

@tobemonkey I cannot comment on the change itself, but this condition does not seem specific to 8 and is also present in newest jdk. Changes should generally go to newest jdk (unless it is something specific to old jdk). Then it can backported (gradually from newest to oldest), if desired.

zzambers avatar Oct 03 '24 10:10 zzambers

@tobemonkey This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '24 15:10 bridgekeeper[bot]

@tobemonkey This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Nov 28 '24 21:11 bridgekeeper[bot]