8328999: Update GIFlib to 5.2.2

[gnu-andrew]

This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the giflib.md file in 11u and later to the THIRD_PARTY_README file in 8u (now only one copy following JDK-8338144)

8u is also missing JDK-8225487 which I've included as part of this patch. This updates the license to credit openbsd-reallocarray.c and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing.

In gif_lib.h, I have restored the workaround for a missing stdbool.h on Windows only. This is needed to build on Visual Studio 2010.

The giflib.md changes include some odd changes, replacing the giflib VCS URL with just tree/README. I've raised 8339271 to correct this and will look at backporting that as a follow-up.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [ ] JDK-8225487 needs maintainer approval
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8328999 needs maintainer approval

Issues

• JDK-8328999: Update GIFlib to 5.2.2 (Bug - P3)
• JDK-8225487: giflib legal file is missing attribution for openbsd-reallocarray.c. (Bug - P4)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer) 🔄 Re-review required (review applies to f953b2bb)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/571/head:pull/571
$ git checkout pull/571

Update a local copy of the PR:
$ git checkout pull/571
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 571

View PR using the GUI difftool:
$ git pr show -t 571

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/571.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 04: Full - Incremental (f953b2bb)
• 03: Full - Incremental (7181dd57)
• 02: Full - Incremental (b9da9e97)
• 01: Full - Incremental (40ab6a93)
• 00: Full (d96b50f0)

[bridgekeeper[bot]]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

/issue add JDK-8225487

[openjdk[bot]]

@gnu-andrew Adding additional issue to issue list: 8225487: giflib legal file is missing attribution for openbsd-reallocarray.c..

[gnu-andrew]

I've restored the workaround for stdbool.h which was present in gif_lib.h but removed in this patch on later JDK versions. This is still needed on Windows with VS2010.

[gnu-andrew]

I've restored the workaround for stdbool.h which was present in gif_lib.h but removed in this patch on later JDK versions. This is still needed on Windows with VS2010.

And now, of course, it fails to download VS2010.

[zzambers]

I've restored the workaround for stdbool.h which was present in gif_lib.h but removed in this patch on later JDK versions. This is still needed on Windows with VS2010.

And now, of course, it fails to download VS2010.

There was an attack on archive.org, causing outage. Seems VS2010 download is now working again.

[openjdk[bot]]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[gnu-andrew]

I've restored the workaround for stdbool.h which was present in gif_lib.h but removed in this patch on later JDK versions. This is still needed on Windows with VS2010.

And now, of course, it fails to download VS2010.

There was an attack on archive.org, causing outage. Seems VS2010 download is now working again.

Yes, thanks, I was watching their Twitter feed on this. I'll merge with latest and see if we can get a VS2010 build now.

[bridgekeeper[bot]]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Ugh, still seeing VS2010 build errors. Will take a look tomorrow.

[bridgekeeper[bot]]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Keep open. Will look after the 8u442 release.

[bridgekeeper[bot]]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@gnu-andrew This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[gnu-andrew]

/open

[openjdk[bot]]

@gnu-andrew This pull request is now open

[jerboaa]

Could you merge latest master, please?

[kurashige23]

Hi. I would be happy if this PR verification goes forward. Thanks.

[bridgekeeper[bot]]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@gnu-andrew This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[jerboaa]

@gnu-andrew Could you move this PR forward, please?

[gnu-andrew]

/open

[openjdk[bot]]

@gnu-andrew This pull request is now open

[jerboaa]

@gnu-andrew Remaining jdk_security_infra tests should be "fixed" with https://github.com/openjdk/jdk8u-dev/pull/695

[gnu-andrew]

@gnu-andrew Remaining jdk_security_infra tests should be "fixed" with #695

Thanks. I'll merge once those are both in.

Also want to propose the last fix upstream as seems to be broken there too.

[bridgekeeper[bot]]

@gnu-andrew This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!