jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8223482: Unsupported ciphersuites may be offered by a TLS client

Open sendaoYan opened this issue 1 year ago • 3 comments

Hi all, This PR is backport of JDK-8223482, backport parity with 8u261 and emb-8u261.

The change of JDK-8223482 of two filessrc/java.base/share/classes/sun/security/ssl/SSLCipher.java and src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java has already in jdk8u-dev, make this backport clean. The file test/jdk/sun/security/pkcs11/fips/TestTLS12.java is backported cleanly.

The test test/jdk/sun/security/pkcs11/fips/TestTLS12.java run failed before this PR, run passed after this PR.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8223482 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8223482: Unsupported ciphersuites may be offered by a TLS client (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/566/head:pull/566
$ git checkout pull/566

Update a local copy of the PR:
$ git checkout pull/566
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 566

View PR using the GUI difftool:
$ git pr show -t 566

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/566.diff

sendaoYan avatar Aug 22 '24 07:08 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 22 '24 07:08 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Aug 22 '24 07:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 22 '24 07:08 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 17 '24 10:10 bridgekeeper[bot]

wait

sendaoYan avatar Oct 17 '24 11:10 sendaoYan

I think it's not quite strong necessary to backport this PR, sorry for the interrupt.

sendaoYan avatar Nov 21 '24 02:11 sendaoYan