8250825: C2 crashes with assert(field != __null) failed: missing field

[sendaoYan]

Hi all, This is backport of JDK-8250825. It's prefixed PR for JDK-8255466 backport. New test fails without the patch, passes with it.

There are two parts make this backport not clean:

1. Patch does not apply cleanly due to different context, before JDK-8250825 the PR JDK-8230505 change releated lines, and I think JDK-8230505 do not needed backport to jdk8u-dev.
2. The added testcase can't backport to jdk8u directly, import jdk.internal.misc.Unsafe should instead of import sun.misc.Unsafe in jdk8u.

Additional testing:

• [x] linux x64 tier1/2/3 jtreg test
• [x] inux aarch64 tier1/2/3 jtreg test

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8250825 needs maintainer approval

Issue

• JDK-8250825: C2 crashes with assert(field != __null) failed: missing field (Bug - P3 - Requested)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/552/head:pull/552
$ git checkout pull/552

Update a local copy of the PR:
$ git checkout pull/552
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 552

View PR using the GUI difftool:
$ git pr show -t 552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/552.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250825: C2 crashes with assert(field != __null) failed: missing field

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

• 492acd3ac4b4fbd4bfe90a00d8f5cd48ffbe372c: 8265019: Update tests for additional TestNG test permissions
• 3683a81d332c26737bef1f0b59b4d68ae4242c09: Merge
• 129290d2ffe3f77ad574bfad8b1ab44f5f3b8fbe: 8339180: Enhanced Building of Processes: Follow-on Issue
• c2f7e61272996631585153c70d784e7690763f01: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
• 2d042cfa40532e28b697c5a53bd282c2319d2f02: 8336564: Enhance mask blit functionality redux
• 1a447c78dd71929d50f91698204a7c66e41acfb9: 8335428: Enhanced Building of Processes
• 1a6e3a5ea32d5c671cb46a590046f16426089921: 8342822: jdk8u432-b06 does not compile on AIX
• 5a4b44089f3f95b92620ef3a7b49f2390b70afaa: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
• d407d631f80559a5fed251d9fef2cef64ddf7936: 8345504: Bump update version of OpenJDK: 8u452
• 2931b1d250dbf820b2094b67f5ae19d223e7c887: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F
• ... and 82 more: https://git.openjdk.org/jdk8u-dev/compare/c8d52b07e18552105d653667e003c566db33e5dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (f0bba3ee)
• 00: Full (7f528207)

[sendaoYan]

The new test fails GHA.

Yes, that's the reason this PR still in Draft status, I will fix the test these days.

[openjdk[bot]]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[sendaoYan]

After the additional test finish, I will make approval request.

[sendaoYan]

The new test fails GHA.

The test fails has been fixed now.

[sendaoYan]

The GHA report several failures:

1. macos x64 runtime/7158988/FieldMonitor.java fails VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification. This test also fails in PR551, I think it's unrelated to this PR.
2. macos x64 compiler/unsafe/OpaqueAccesses.java fails SIGSEGV in Unsafe_GetInt, This test also fails in PR551, I think it's unrelated to this PR.
3. macos x64 all the com/sun/jdi testcases fails transport error 202: gethostbyname: unknown host, seems to be GHA environmental issue.

[sendaoYan]

/approval request Backport JDK-8250825, New test fails without the patch, passes with it. All the jtreg tests on linux x86_64 and aarch64 shows no new failure.

[openjdk[bot]]

@sendaoYan 8250825: The approval request has been created successfully.

[zzambers]

The GHA report several failures:

1. macos x64 `runtime/7158988/FieldMonitor.java` fails `VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification`. This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.

2. macos x64 `compiler/unsafe/OpaqueAccesses.java` fails `SIGSEGV  in Unsafe_GetInt`, This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.

3. macos x64 all the `com/sun/jdi` testcases fails `transport error 202: gethostbyname: unknown host`, seems to be GHA environmental issue.

All these mac issues should be unrelated, see: https://github.com/openjdk/jdk8u-dev/pull/544

[sendaoYan]

After #544 has been merged, does the two jbs issue can be cloesd? @zzambers https://bugs.openjdk.org/browse/JDK-8337185 https://bugs.openjdk.org/browse/JDK-8337183

[sendaoYan]

Thanks for the review.

[zzambers]

After #544 has been merged, does the two jbs issue can be cloesd? @zzambers https://bugs.openjdk.org/browse/JDK-8337185 https://bugs.openjdk.org/browse/JDK-8337183

I have classified problems on MacOS in this coment: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Hi, can anyone take look this backport to jdk8u.

[sendaoYan]

Thanks for the review.

[sendaoYan]

/approval request Fixes the corner case in C2. Patch does not apply cleanly due to different context. New test fails without the patch, passes with it. jtreg tier{1,2,3} also passes.

[openjdk[bot]]

@sendaoYan 8250825: The approval request has been updated successfully.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/approval request Fixes the corner case in C2. Patch does not apply cleanly due to different context. New test fails without the patch, passes with it. jtreg tier{1,2,3,etc.} also passes on linux x86_64 and linux aarch64.

[openjdk[bot]]

@sendaoYan 8250825: The approval request has been updated successfully.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk[bot]]

@sendaoYan This pull request is already open

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk[bot]]

@sendaoYan This pull request is already open

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!