jdk8u-dev
jdk8u-dev copied to clipboard
8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
…lls: 51. After deopt 50"
Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1.
Backported manually from the jdk9u commit below: 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8021775 needs maintainer approval
Issue
- JDK-8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" (Bug - P3)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/545/head:pull/545
$ git checkout pull/545
Update a local copy of the PR:
$ git checkout pull/545
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/545/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 545
View PR using the GUI difftool:
$ git pr show -t 545
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/545.diff
Webrev
:wave: Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@adamfarley This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1.
Reviewed-by: sgehwolf
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 35 new commits pushed to the master branch:
- 933c78ebd5be5aedc2181b95917933dffe7e279c: 8309138: Fix container tests for jdks with symlinked conf dir
- 4fe22e82ebd3640c7999e094903874c9ac7f2391: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
- 855480b9336976cfdeea6ff5f57a712e4119e61a: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
- 4c9c5a4275550fee0dbf46697255c147a8dc98b6: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
- 8b28c35f2efe5f4d6bd2f4e36720ca6a529836dd: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
- 2afd9188fa17d748dca15bcdc1f39bdb1c6dfca9: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
- 439e910420ab9e1ca7c4645bb20634bc7cdbbe57: 8321480: ISO 4217 Amendment 176 Update
- edbdf0538df3fe764ea6a109c3e07cb145dbfe48: 8336928: GHA: Bundle artifacts removal broken
- 1ca84ad59a4db33ab43cebc7d78ee99f87455be1: 8305400: ISO 4217 Amendment 175 Update
- ea76f37ddb113b84f5421d64e687e1b6b7a13ea6: 8338144: [8u] Remove duplicate license files
- ... and 25 more: https://git.openjdk.org/jdk8u-dev/compare/fc15e99a3218a88434c27da1d7d09a01c592d8f9...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
This backport pull request has now been updated with issue and summary from the original commit.
@adamfarley This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval "Requesting a backport of this fix to prevent the issue documented in JDK-8330973. It's a clean merge."
@adamfarley usage: /approval [<id>] (request|cancel) [<text>]
/approval request "Requesting a backport of this fix to prevent the issue documented in JDK-8330973. It's a clean merge."
@adamfarley 8021775: The approval request has been created successfully.
I will be going on vacation shortly. Please feel free to integrate this PR once sponsored. Thank you. :)
@adamfarley Please add /integrate and I'll sponsor.
See https://github.com/openjdk/jdk8u-dev/pull/545#issuecomment-2220291127 for the details.
Afterwards, right. Got mixed up. Thanks for clarifying.
/integrate
@adamfarley Your change (at version 84a48f241b2b0be05dc0378980eff311ecf44720) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit 5c7f201af69a500b06a345f84a5b1ce550b605b2.
Since your change was applied there have been 35 commits pushed to the master branch:
- 933c78ebd5be5aedc2181b95917933dffe7e279c: 8309138: Fix container tests for jdks with symlinked conf dir
- 4fe22e82ebd3640c7999e094903874c9ac7f2391: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
- 855480b9336976cfdeea6ff5f57a712e4119e61a: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
- 4c9c5a4275550fee0dbf46697255c147a8dc98b6: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
- 8b28c35f2efe5f4d6bd2f4e36720ca6a529836dd: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
- 2afd9188fa17d748dca15bcdc1f39bdb1c6dfca9: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
- 439e910420ab9e1ca7c4645bb20634bc7cdbbe57: 8321480: ISO 4217 Amendment 176 Update
- edbdf0538df3fe764ea6a109c3e07cb145dbfe48: 8336928: GHA: Bundle artifacts removal broken
- 1ca84ad59a4db33ab43cebc7d78ee99f87455be1: 8305400: ISO 4217 Amendment 175 Update
- ea76f37ddb113b84f5421d64e687e1b6b7a13ea6: 8338144: [8u] Remove duplicate license files
- ... and 25 more: https://git.openjdk.org/jdk8u-dev/compare/fc15e99a3218a88434c27da1d7d09a01c592d8f9...master
Your commit was automatically rebased without conflicts.
@jerboaa @adamfarley Pushed as commit 5c7f201af69a500b06a345f84a5b1ce550b605b2.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.