8255466: C2 crashes at ciObject::get_oop() const+0x0

[sendaoYan]

Hi all, This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning hotspot/src/share/vm/opto/type.cpp:2556:71: error: ‘this’ pointer is null with gcc13. Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add bootclasspath. New test fails without the patch, passes with it.

Additional testing:

• [x] linux x64 tier1/2/3 jtreg test
• [x] linux aarch64 tier1/2/3 jtreg test

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8255466 needs maintainer approval

Issue

• JDK-8255466: C2 crashes at ciObject::get_oop() const+0x0 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/536/head:pull/536
$ git checkout pull/536

Update a local copy of the PR:
$ git checkout pull/536
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 536

View PR using the GUI difftool:
$ git pr show -t 536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/536.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255466: C2 crashes at ciObject::get_oop() const+0x0

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 4c5094095fade410e23e6a071c93c7e4fdc1dade: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (f00511fd)
• 01: Full (5abad68b)
• 00: Full (95f32428)

[sendaoYan]

The GHA report several failures.

1. Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3

2. Linux x86 gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java report crash CompactibleFreeListSpace::block_size(HeapWord const*), which has been recorded by JDK-8303159, it's unrelated to this PR.
3. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

[sendaoYan]

/approval request Backport JDK-8255466 to fix the corner case in C2. The change has been verified on linux x64 and linux aarch64 with jtreg tier1/2/3.

[openjdk[bot]]

@sendaoYan 8255466: The approval request has been created successfully.

[sendaoYan]

This backport includes a backport of JDK-8250825. Please either do that backport first, or merge it with this PR.

Thanks very much for your patience and careful review. I have created a backport PR of JDK-8250825.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Wait the prefixed PR merged. /approval cancel

[openjdk[bot]]

@sendaoYan 8255466: The approval request has been cancelled successfully.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Wait the prefixed https://github.com/openjdk/jdk8u-dev/pull/552 merged.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk[bot]]

@sendaoYan This pull request is already open

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk[bot]]

@sendaoYan This pull request is already open

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk[bot]]

@sendaoYan This pull request is already open

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Prefixed backport has been merged. Can anyone review this backport, thanks.

[openjdk[bot]]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[sendaoYan]

Thanks for the review @phohensee

[gnu-andrew]

/reviewers 2 reviewer

[openjdk[bot]]

@gnu-andrew The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[sendaoYan]

GHA report several test failures, expect the CA issue which has been fixing by https://github.com/openjdk/jdk8u-dev/pull/526. Other failure shows as below:

1. Macos x64 'compiler/unsafe/OpaqueAccesses.java' fails 'SIGSEGV in Unsafe_GetInt', This test also fails in PR551 and fixing by https://github.com/openjdk/jdk8u-dev/pull/553, it's unrelated to this PR.
2. Macos x64 'com/sun/jdi/PrivateTransportTest.sh' fails 'JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized', which recorded by JDK-8216265. This test also fails in https://github.com/openjdk/jdk8u-dev/pull/551,it's unralated to this PR.
3. Macos x64 'sun/misc/CopyMemory.java' fails 'Unsafe_SetByte', this issue fixing by https://github.com/openjdk/jdk8u-dev/pull/553, it's unralated to this PR.

[gnu-andrew]

GHA report several test failures, expect the CA issue which has been fixing by #526.

#526 doesn't fix the issue. It hides it. The right solution is to fix the offending case or at least exclude it, as has been done in the past.

Other failure shows as below:

1. Macos x64 'compiler/unsafe/OpaqueAccesses.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461702188) 'SIGSEGV  in Unsafe_GetInt', This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551) and fixing by [8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553](https://github.com/openjdk/jdk8u-dev/pull/553), it's unrelated to this PR.

2. Macos x64 'com/sun/jdi/PrivateTransportTest.sh' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized', which recorded by [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). This test also fails in [8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory #551](https://github.com/openjdk/jdk8u-dev/pull/551) unralated to this PR.

3. Macos x64 'sun/misc/CopyMemory.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'Unsafe_SetByte', this issue fixing by [8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553](https://github.com/openjdk/jdk8u-dev/pull/553), it's unrelated to this PR.

Thanks for tracking these down. I didn't realise they all had PRs. I'll try and look over them tomorrow.