8334441: Mark tests in jdk_security_infra group as manual

[sendaoYan]

Hi all,

This pull request contains a backport of commit 1e3e6877 from the openjdk/jdk11u repository.

The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr.

The file rename from jdk/test/TEST.groups to test/jdk/TEST.groups by JDK-8187443, and the two file has almost totally different commit history, thus make this backport uncleanly.

Thanks!

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8334441 needs maintainer approval

Issue

• JDK-8334441: Mark tests in jdk_security_infra group as manual (Bug - P3 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/526/head:pull/526
$ git checkout pull/526

Update a local copy of the PR:
$ git checkout pull/526
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/526/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 526

View PR using the GUI difftool:
$ git pr show -t 526

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/526.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (a8ef5f64)
• 01: Full - Incremental (7635fb48)
• 00: Full (0ba32695)

[sendaoYan]

/approval request Backport JDK-8334441 to make some CA testcases as manual, no risk.

[openjdk[bot]]

@sendaoYan 8334441: The approval request has been created successfully.

[sendaoYan]

The GHA test runner report several failures, all the failures was recorded by JDK-8334732, unralated to this PR.

1. linux x64
2. linux x86
3. windows x64
4. windows x86

[gnu-andrew]

test/jdk/TEST.groups not exists in jdk8u-dev, and it not need to backport.

No, because it's jdk/test/TEST.groups: https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/TEST.groups

With JDK-8315757, we added jdk_security_infra to tier_1 so it received more testing. This proposed change seems to be going in the opposite direction and will mean failures in the certificate tests are completely missed.

/approval no

[openjdk[bot]]

@gnu-andrew Only the author (@sendaoYan) is allowed to issue the /approval command.

[gnu-andrew]

/approve no

[openjdk[bot]]

@gnu-andrew 8334441: The approval request has been rejected.

[gnu-andrew]

The GHA test runner report several failures, all the failures was recorded by JDK-8334732, unralated to this PR.

1. linux x64

2. linux x86

3. windows x64

4. windows x86

It looks like JDK-8030204 was pushed after you created your fork. This should now be fixed.

[sendaoYan]

It looks like JDK-8030204 was pushed after you created your fork. This should now be fixed.

Thanks for the remind. I have merged the fixed in this PR.

[sendaoYan]

test/jdk/TEST.groups not exists in jdk8u-dev, and it not need to backport.

No, because it's jdk/test/TEST.groups: https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/TEST.groups

With JDK-8315757, we added jdk_security_infra to tier_1 so it received more testing. This proposed change seems to be going in the opposite direction and will mean failures in the certificate tests are completely missed.

/approval no

Sorry, I didn't describe the problem accurately. The file rename from jdk/test/TEST.groups to test/jdk/TEST.groups by JDK-8187443, and the two file has almost totally different commit history, thus make this backport uncleanly. The original commit 1e3e6877 only add two comment lines for file test/jdk/TEST.groups, so I used to simply think it's not need to backport to jdk8u-dev. I will backport the two lines also.

[openjdk[bot]]

⚠️ @sendaoYan This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[sendaoYan]

It looks like JDK-8030204 was pushed after you created your fork. This should now be fixed.

Thanks for the remind. I have merged the fixed in this PR.

The GHA test runner report a failure, I think it's unrelated to this PR.

1. gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java timeout

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk[bot]]

@sendaoYan This pull request is already open

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[openjdk[bot]]

@wkia Only the pull request author can set the pull request state to "open"

[wkia]

I'd like to see this integrated.

@sendaoYan will you continue waiting for review approval?

[sendaoYan]

@sendaoYan will you continue waiting for review approval?

I am not quite sure that does this PR needed to integrated or not.

[wkia]

I am not quite sure that does this PR needed to integrated or not.

It'd help with running jtreg tests on jdk8. Currently these tests fail if running the complete bundle like tier1 or whatever.

[mrserb]

This fix was integrated into Oracle 8u441, it will be good to take it into OpenJDK 8.

[sendaoYan]

This fix was integrated into Oracle 8u441, it will be good to take it into OpenJDK 8.

Okey.

/open

[openjdk[bot]]

@sendaoYan This pull request is now open

[openjdk[bot]]

@sendaoYan This pull request is already open

[gnu-andrew]

I still don't think this is the right approach and the fact that one has gone unfixed for so long seems to back that up.