jdk8u-dev 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML

Hi all,

JDK8 reproduces the reported bug and I would like to backport this patch. The patch is not clean.

Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method.
Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9.

There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518

Testing: All tests under jdk/test/javax/xml/jaxp/

Thank you.

Progress

[x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
[x] Change must not contain extraneous whitespace
[x] Commit message must refer to an issue
[ ] JDK-8268457 needs maintainer approval

Issue

JDK-8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML (Bug - P4 - Requested)

Reviewers

Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/517/head:pull/517
$ git checkout pull/517

Update a local copy of the PR:
$ git checkout pull/517
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 517

View PR using the GUI difftool:
$ git pr show -t 517

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/517.diff

Webrev

Link to Webrev Comment

Jun 11 '24 04:06 ktakakuri

:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Jun 11 '24 04:06 bridgekeeper[bot]

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

e4297a70459accd845420180f9bae19b78fe340e: 8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925
ed3d731386bf4f6819d5e5f69376e520df3a6262: 8342841: [8u] Separate jdk_security_infra tests from jdk_tier1
1d2f46702819a866f5291a0e6338ea0c7ccc1927: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows
41f479c4801ebbf96e1d6bebe1d26d3a5f7a4dc1: 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode
7e1ea515911827915c27c6568585c6c7906a74d9: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method
31b88042fba46e87fba83e8bfd43ae0ecb5a9afd: Merge
618917eb093243de2c5d7e83d4688bfe9ad04985: 8341059: Change Entrust TLS distrust date to November 12, 2024
1c1afe3188df5621b5523ae9a06ad39c8a253589: 8341057: Add 2 SSL.com TLS roots
e976b99775c95013431b7119a61dac3409b3bf16: 8335713: Enhance vectorization analysis
c5508ab0a6f565bb774ccf786f3290e59f5ab116: 8332644: Improve graph optimizations
... and 100 more: https://git.openjdk.org/jdk8u-dev/compare/6b53212ef78ad50f9eede829c5ff87cadcdb434b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Jun 11 '24 04:06 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

Jun 11 '24 04:06 openjdk[bot]

Webrevs

00: Full (b03f86e3)

Jun 11 '24 04:06 mlbridge[bot]

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Jun 11 '24 16:06 openjdk[bot]

GHA test failures appear infrastructure related.

Jun 11 '24 16:06 phohensee

/approval request JDK8 reproduces the reported bug and I would like to backport this patch. There is a low risk because the logic around the changes is the same as JDK18. The original patch does not apply cleanly to 8u, but I verified that it works. There is a related patch JDK-8274606, and I have proposed a separate backport for it. Testing: All tests under jdk/test/javax/xml/jaxp/

Jun 12 '24 09:06 ktakakuri

@ktakakuri 8268457: The approval request has been created successfully.

Jun 12 '24 09:06 openjdk[bot]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Jul 10 '24 12:07 bridgekeeper[bot]