jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo

Open sendaoYan opened this issue 1 year ago • 21 comments
trafficstars

Hi all, This is backport of JDK-8048215. This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8048215 needs maintainer approval

Issue

  • JDK-8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/504/head:pull/504
$ git checkout pull/504

Update a local copy of the PR:
$ git checkout pull/504
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 504

View PR using the GUI difftool:
$ git pr show -t 504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/504.diff

Webrev

Link to Webrev Comment

sendaoYan avatar May 23 '24 02:05 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 23 '24 02:05 bridgekeeper[bot]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo

Ensure the target thread has reached wait() before inspecting it

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 106 new commits pushed to the master branch:

  • 492acd3ac4b4fbd4bfe90a00d8f5cd48ffbe372c: 8265019: Update tests for additional TestNG test permissions
  • 3683a81d332c26737bef1f0b59b4d68ae4242c09: Merge
  • 129290d2ffe3f77ad574bfad8b1ab44f5f3b8fbe: 8339180: Enhanced Building of Processes: Follow-on Issue
  • c2f7e61272996631585153c70d784e7690763f01: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
  • 2d042cfa40532e28b697c5a53bd282c2319d2f02: 8336564: Enhance mask blit functionality redux
  • 1a447c78dd71929d50f91698204a7c66e41acfb9: 8335428: Enhanced Building of Processes
  • 1a6e3a5ea32d5c671cb46a590046f16426089921: 8342822: jdk8u432-b06 does not compile on AIX
  • 5a4b44089f3f95b92620ef3a7b49f2390b70afaa: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
  • d407d631f80559a5fed251d9fef2cef64ddf7936: 8345504: Bump update version of OpenJDK: 8u452
  • 2931b1d250dbf820b2094b67f5ae19d223e7c887: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F
  • ... and 96 more: https://git.openjdk.org/jdk8u-dev/compare/6abb3f27b9a535f741c7d3a8dfa0d6b811263a9e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar May 23 '24 02:05 openjdk[bot]

This backport pull request has now been updated with issue and summary from the original commit.

openjdk[bot] avatar May 23 '24 02:05 openjdk[bot]

/approval request Backport which try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.

sendaoYan avatar May 23 '24 02:05 sendaoYan

@sendaoYan 8048215: The approval request has been created successfully.

openjdk[bot] avatar May 23 '24 02:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 23 '24 02:05 mlbridge[bot]

The GHA test runner report 4 failures. All the failures seems environmental issue, unreleated to this PR.

sendaoYan avatar May 23 '24 03:05 sendaoYan

The GHA report failure CAInterop.java#digicerttlsrsarootg5 and CAInterop.java#quovadisrootca1g3, which has been record in JDK-8324583, unrelated to this PR. The GHA report failure gc/6581734/Test6581734.java, I have created a new issue JDK-8332853 to record this failure. It's unrelated to this PR.

Other failures reported by GHA seems to environmental issues, unrelated to this PR.

sendaoYan avatar May 24 '24 02:05 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 21 '24 08:06 bridgekeeper[bot]

Hi all, can anyone take a review to this PR.

sendaoYan avatar Jun 21 '24 09:06 sendaoYan

The GHA test runner report 3 failures:

  1. com/sun/jdi/JdbExprTest.sh, unrelated to this PR. I has created a issue to record ths failure.
  2. security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootrsaca fails, unrelated to this PR, which is fixing.
  3. security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca fails, unrelated to this PR, which is fixing.

sendaoYan avatar Jun 21 '24 15:06 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 19 '24 19:07 bridgekeeper[bot]

/open

sendaoYan avatar Jul 20 '24 03:07 sendaoYan

@sendaoYan This pull request is already open

openjdk[bot] avatar Jul 20 '24 03:07 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 17 '24 05:08 bridgekeeper[bot]

Hi, can anyone task look this PR.

sendaoYan avatar Aug 17 '24 11:08 sendaoYan

GHA failures are unrelated.

phohensee avatar Aug 19 '24 17:08 phohensee

Thanks for the review.

sendaoYan avatar Aug 20 '24 01:08 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 17 '24 05:09 bridgekeeper[bot]

/approval request Backport to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.

sendaoYan avatar Sep 17 '24 07:09 sendaoYan

@sendaoYan 8048215: The approval request has been updated successfully.

openjdk[bot] avatar Sep 17 '24 07:09 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 15 '24 10:10 bridgekeeper[bot]

/open

sendaoYan avatar Oct 15 '24 11:10 sendaoYan

@sendaoYan This pull request is already open

openjdk[bot] avatar Oct 15 '24 11:10 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Nov 12 '24 15:11 bridgekeeper[bot]

/open

sendaoYan avatar Nov 12 '24 16:11 sendaoYan

@sendaoYan This pull request is already open

openjdk[bot] avatar Nov 12 '24 16:11 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Dec 10 '24 19:12 bridgekeeper[bot]

/open

sendaoYan avatar Dec 11 '24 02:12 sendaoYan

@sendaoYan This pull request is already open

openjdk[bot] avatar Dec 11 '24 02:12 openjdk[bot]