jdk8u-dev
jdk8u-dev copied to clipboard
8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id
Hi all,
This pull request contains a backport of commit 29f300eb from the openjdk/jdk11u-dev repository.
The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.
Thanks!
Progress
- [ ] JDK-8322511 needs maintainer approval
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id (Bug - P4 - Requested)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/486/head:pull/486
$ git checkout pull/486
Update a local copy of the PR:
$ git checkout pull/486
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/486/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 486
View PR using the GUI difftool:
$ git pr show -t 486
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/486.diff
Webrev
:wave: Welcome back jwtang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
This backport pull request has now been updated with issue from the original commit.
/clean
Only file location differs.
@phohensee This backport pull request is now marked as clean
⚠️ @jia-wei-tang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
Many GHA infra issues, plus what seem to be unrelated test failures.
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Hi, the ci tests failure seems to be unrelated to my backport. Can anyone help me?
Some outputs of those failure: E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages (Linux additional (hs s390x build only)) Error: Unable to find any artifacts for the associated workflow (Linux x64 (jdk/tier1))
If all the failures are infra issues, then just go ahead and request maintainer approval.
@phohensee Could you pls approve this JDK-8322511 and review the codes? It's a clean backport.
I'm not a maintainer, so can't approve backports. Review, yes, approve, no.
Please use the "/approval request <text describing reason for backport, testing, and risk>" PR comment to request approval by a maintainer.
/approval request this backport of commit 29f300eb from the openjdk/jdk11u-dev repository. The JVM crashes when using JFR. It's a clean backport.
@jia-wei-tang 8322511: The approval request has been created successfully.
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@mgronlun Hi, could you approve this request? The JVM crashes when using JFR. It's a clean backport.
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Hi, how could I get the approval ?
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Hi, anyone can help me with this approval?