jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id

Open jia-wei-tang opened this issue 1 year ago • 19 comments

Hi all,

This pull request contains a backport of commit 29f300eb from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.

Thanks!


Progress

  • [ ] JDK-8322511 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/486/head:pull/486
$ git checkout pull/486

Update a local copy of the PR:
$ git checkout pull/486
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 486

View PR using the GUI difftool:
$ git pr show -t 486

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/486.diff

Webrev

Link to Webrev Comment

jia-wei-tang avatar Apr 23 '24 06:04 jia-wei-tang

:wave: Welcome back jwtang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 23 '24 06:04 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Apr 23 '24 06:04 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Apr 23 '24 06:04 openjdk[bot]

Webrevs

mlbridge[bot] avatar Apr 23 '24 06:04 mlbridge[bot]

/clean

Only file location differs.

phohensee avatar Apr 23 '24 16:04 phohensee

@phohensee This backport pull request is now marked as clean

openjdk[bot] avatar Apr 23 '24 16:04 openjdk[bot]

⚠️ @jia-wei-tang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Apr 23 '24 16:04 openjdk[bot]

Many GHA infra issues, plus what seem to be unrelated test failures.

phohensee avatar Apr 23 '24 16:04 phohensee

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 21 '24 20:05 bridgekeeper[bot]

Hi, the ci tests failure seems to be unrelated to my backport. Can anyone help me?

Some outputs of those failure: E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages (Linux additional (hs s390x build only)) Error: Unable to find any artifacts for the associated workflow (Linux x64 (jdk/tier1))

jia-wei-tang avatar May 22 '24 06:05 jia-wei-tang

If all the failures are infra issues, then just go ahead and request maintainer approval.

phohensee avatar Jun 10 '24 17:06 phohensee

@phohensee Could you pls approve this JDK-8322511 and review the codes? It's a clean backport.

jia-wei-tang avatar Jun 19 '24 02:06 jia-wei-tang

I'm not a maintainer, so can't approve backports. Review, yes, approve, no.

Please use the "/approval request <text describing reason for backport, testing, and risk>" PR comment to request approval by a maintainer.

phohensee avatar Jun 19 '24 14:06 phohensee

/approval request this backport of commit 29f300eb from the openjdk/jdk11u-dev repository. The JVM crashes when using JFR. It's a clean backport.

jia-wei-tang avatar Jun 26 '24 01:06 jia-wei-tang

@jia-wei-tang 8322511: The approval request has been created successfully.

openjdk[bot] avatar Jun 26 '24 01:06 openjdk[bot]

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 24 '24 05:07 bridgekeeper[bot]

@mgronlun Hi, could you approve this request? The JVM crashes when using JFR. It's a clean backport.

jia-wei-tang avatar Jul 25 '24 02:07 jia-wei-tang

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 22 '24 03:08 bridgekeeper[bot]

Hi, how could I get the approval ?

jia-wei-tang avatar Sep 02 '24 06:09 jia-wei-tang

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 30 '24 06:09 bridgekeeper[bot]

Hi, anyone can help me with this approval?

jia-wei-tang avatar Sep 30 '24 06:09 jia-wei-tang