jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

Published 20 hours ago • verified publisher icon openjdk

8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests.

Open yaqsun opened this issue 1 year ago • 38 comments

This backport has modified the following aspects:

  • there are 53 cases that do not exist: jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java jdk/test/java/awt/Frame/8158918/SetExtendedState.java jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java jdk/test/javax/swing/JButton/8151303/PressedIconTest.java jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/JList/8161483/Bug8161483.java jdk/test/javax/swing/JMenu/8067346/bug8067346.java jdk/test/javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java jdk/test/javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java jdk/test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java jdk/test/javax/swing/JMenuItem/ClickMenuTestManual/ClickMenuTestManual.java jdk/test/javax/swing/JOptionPane/8081019/bug8081019.java jdk/test/javax/swing/JTable/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/JTableHeader/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java jdk/test/javax/swing/JTree/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/plaf/basic/6866751/bug6866751.java jdk/test/javax/swing/plaf/windows/6921687/bug6921687.java jdk/test/javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java jdk/test/javax/swing/text/GlyphPainter2/6427244/bug6427244.java jdk/test/javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java jdk/test/javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java jdk/test/sun/awt/image/OffScreenImageSource/ImageConsumerUnregisterTest.java jdk/test/sun/java2d/xrender/HugeGradientTest.java
  • context conflicts are handled jdk/test/javax/swing/system/6799345/TestShutdown.java jdk/test/javax/swing/Security/6938813/bug6938813.java jdk/test/javax/swing/JComboBox/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/JTextArea/6940863/bug6940863.java jdk/test/javax/swing/JPopupMenu/7154841/bug7154841.java jdk/test/javax/swing/JInternalFrame/Test6325652.java jdk/test/javax/swing/JFrame/8016356/bug8016356.java jdk/test/javax/swing/JFileChooser/6817933/Test6817933.java jdk/test/javax/swing/JFileChooser/6713352/bug6713352.java jdk/test/javax/swing/JComponent/8043610/bug8043610.java jdk/test/java/awt/print/PrinterJob/PrintCrashTest.java jdk/test/java/awt/print/PrinterJob/Margins.java jdk/test/java/awt/image/multiresolution/MultiResolutionToolkitImageTest.java jdk/test/TEST.ROOT jdk/test/com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java jdk/test/com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java jdk/test/java/awt/Desktop/DesktopGtkLoadTest/DesktopGtkLoadTest.java jdk/test/java/awt/Dialog/CloseDialog/CloseDialogTest.java jdk/test/java/awt/EmbeddedFrame/DisplayChangedTest/DisplayChangedTest.java jdk/test/java/awt/EmbeddedFrame/EmbeddedFrameGrabTest/EmbeddedFrameGrabTest.java jdk/test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html jdk/test/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java jdk/test/java/awt/Frame/NormalToIconified/NormalToIconifiedTest.java jdk/test/java/awt/Frame/SetMaximizedBounds/SetMaximizedBounds.java jdk/test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java jdk/test/java/awt/font/TextLayout/TestSinhalaChar.java jdk/test/java/awt/im/8041990/bug8041990.java jdk/test/java/awt/image/MultiResolutionImageTest.java jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java
  • context is adapted where needed

Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] JDK-8186259 needs maintainer approval
  • [x] Commit message must refer to an issue
  • [x] JDK-8185500 needs maintainer approval

Issues

  • JDK-8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. (Bug - P4 - Approved)
  • JDK-8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java (Bug - P1 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464
$ git checkout pull/464

Update a local copy of the PR:
$ git checkout pull/464
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 464

View PR using the GUI difftool:
$ git pr show -t 464

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/464.diff

Using Webrev

Link to Webrev Comment

yaqsun avatar Mar 04 '24 02:03 yaqsun

:wave: Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 04 '24 02:03 bridgekeeper[bot]

This backport pull request has now been updated with issue and summary from the original commit.

openjdk[bot] avatar Mar 04 '24 02:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 04 '24 02:03 mlbridge[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

the two cases no longer exist in the high version jdk, so backport is not performed jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

The test is still there in the jdk8u-dev:

mrserb avatar Apr 01 '24 00:04 mrserb

the two cases no longer exist in the high version jdk, so backport is not performed jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

The test is still there in the jdk8u-dev:

The above two cases have been backport.

yaqsun avatar Apr 01 '24 06:04 yaqsun

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca always fail in test results.

yaqsun avatar Apr 19 '24 02:04 yaqsun

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 17 '24 06:05 bridgekeeper[bot]

/issue add JDK-8186259

yaqsun avatar Jun 18 '24 02:06 yaqsun

@yaqsun Adding additional issue to issue list: 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java.

openjdk[bot] avatar Jun 18 '24 02:06 openjdk[bot]

/issue add JDK-8293767

yaqsun avatar Jun 25 '24 01:06 yaqsun

@yaqsun Adding additional issue to issue list: 8293767: AWT test TestSinhalaChar.java has old SCCS markings.

openjdk[bot] avatar Jun 25 '24 01:06 openjdk[bot]

/issue add JDK-8293767

You do not need to add it to the list of this PR, that issue was already fixed in the OpenJDK8(long ago in openjdk8u372). The problem was in the previous version of the current PR which reverts the patch for JDK-8293767.

mrserb avatar Jun 25 '24 16:06 mrserb

/issue remove JDK-8293767

yaqsun avatar Jun 26 '24 01:06 yaqsun

@yaqsun Removing additional issue from issue list: 8293767.

openjdk[bot] avatar Jun 26 '24 01:06 openjdk[bot]

⚠️ @yaqsun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jul 04 '24 06:07 openjdk[bot]

/approval 8186259 request IOExceptionIfEncodedURLTest.sh and IOExceptionIfEncodedURLTest.java have similar names, fixed according to JDK-8186259.

yaqsun avatar Jul 04 '24 07:07 yaqsun

@yaqsun 8186259: The approval request has been created successfully.

openjdk[bot] avatar Jul 04 '24 07:07 openjdk[bot]

/approval 8185500 request add '@key headful' and add '@requires (os.family == "windows")' somewhere.

yaqsun avatar Jul 04 '24 07:07 yaqsun

@yaqsun 8185500: The approval request has been created successfully.

openjdk[bot] avatar Jul 04 '24 07:07 openjdk[bot]

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 01 '24 09:08 bridgekeeper[bot]

keep open

mrserb avatar Aug 12 '24 17:08 mrserb

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 09 '24 17:09 bridgekeeper[bot]

@gnu-andrew please take a look

mrserb avatar Sep 10 '24 00:09 mrserb

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 08 '24 03:10 bridgekeeper[bot]