8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test

[yaqsun]

JDK-8164119 remove key attribute headful, MoveToOtherScreenTest fails due wrong key attribute: @key headful isn't included in TEST.ROOT in jdk8. But define "headful" jtreg keyword on JDK-8129822. So add keywords headful in MoveToOtherScreenTest.java test.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8326725 needs maintainer approval

Issue

• JDK-8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test (Bug - P4 - Requested)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer) 🔄 Re-review required (review applies to 3ef97d18)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/460/head:pull/460
$ git checkout pull/460

Update a local copy of the PR:
$ git checkout pull/460
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 460

View PR using the GUI difftool:
$ git pr show -t 460

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/460.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[yaqsun]

/backport jdk8u-dev

[openjdk[bot]]

@yaqsun To use the /backport command, you need to be in the OpenJDK census and your GitHub account needs to be linked with your OpenJDK username (how to associate your GitHub account with your OpenJDK username).

[mlbridge[bot]]

Webrevs

• 04: Full - Incremental (5096551b)
• 03: Full - Incremental (3ef97d18)
• 02: Full - Incremental (71acb539)
• 01: Full - Incremental (39539fe6)
• 00: Full (ac698bc1)

[theaoqi]

I think this should not be a backport of JDK-8164119. Maybe you should file a new JBS ID for this issue.

[yaqsun]

/approval 8326725 cancel

[openjdk[bot]]

@yaqsun 8326725: The approval request has been cancelled successfully.

[openjdk[bot]]

⚠️ @yaqsun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[yaqsun]

/approval 8164119 cancel

[openjdk[bot]]

@yaqsun This issue is not associated with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[bridgekeeper[bot]]

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@yaqsun This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[yaqsun]

/open

[openjdk[bot]]

@yaqsun This pull request is now open

[yaqsun]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

The Progress checklist in the description for automated requirements where can I see it from?

thanks.

[mrserb]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

The Progress checklist in the description for automated requirements where can I see it from?

thanks.

In the description of this PR:

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer) Change must not contain extraneous whitespace Commit message must refer to an issue JDK-8326725 needs maintainer approval

right now this PR does not have the "maintainer approval"

[yaqsun]

/approval 8326725 request

[openjdk[bot]]

@yaqsun 8326725: The approval request has been created successfully.

[yaqsun]

right now this PR does not have the "maintainer approval"

Thank you very much for your answer.

[mrserb]

approval 8326725 request

You should provide the reason for the request and additional details, the list of requirements: https://openjdk.org/projects/jdk-updates/approval.html

[yaqsun]

/approval 8326725 request Define "headful" jtreg keyword on JDK-8129822, so mark MoveToOtherScreenTest.java as @headful. Only this case is affected and the risk is low.

[openjdk[bot]]

@yaqsun 8326725: The approval request has been updated successfully.

[bridgekeeper[bot]]

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper[bot]]

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper[bot]]

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!