jdk8u-dev
jdk8u-dev copied to clipboard
8326110: [8u] The Marlin tests should be updated after JDK-8241307
The tests are updated to force the MarlinRenderingEngine.
@bourgesl please take a look.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8326110 needs maintainer approval
Issue
- JDK-8326110: [8u] The Marlin tests should be updated after JDK-8241307 (Bug - P4 - Requested)
Reviewers
- Laurent Bourgès (@bourgesl - Committer) Review applies to 0ae5ee57
- Paul Hohensee (@phohensee - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/447/head:pull/447
$ git checkout pull/447
Update a local copy of the PR:
$ git checkout pull/447
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/447/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 447
View PR using the GUI difftool:
$ git pr show -t 447
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/447.diff
Webrev
:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
Webrevs
- 04: Full - Incremental (97d06843)
- 03: Full - Incremental (725633e9)
- 02: Full - Incremental (6d22db51)
- 01: Full - Incremental (cfbe4764)
- 00: Full (0ae5ee57)
LGTM 😉
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
/open
@mrserb This pull request is now open
LGTM
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
keep open
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
keep open
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
keep open
⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
keep open