jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8326110: [8u] The Marlin tests should be updated after JDK-8241307

Open mrserb opened this issue 1 year ago • 16 comments

The tests are updated to force the MarlinRenderingEngine.

@bourgesl please take a look.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8326110 needs maintainer approval

Issue

  • JDK-8326110: [8u] The Marlin tests should be updated after JDK-8241307 (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/447/head:pull/447
$ git checkout pull/447

Update a local copy of the PR:
$ git checkout pull/447
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 447

View PR using the GUI difftool:
$ git pr show -t 447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/447.diff

Webrev

Link to Webrev Comment

mrserb avatar Feb 18 '24 03:02 mrserb

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 18 '24 03:02 bridgekeeper[bot]

LGTM 😉

bourgesl avatar Feb 18 '24 07:02 bourgesl

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 11 '24 20:04 bridgekeeper[bot]

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar May 10 '24 01:05 bridgekeeper[bot]

/open

mrserb avatar May 10 '24 01:05 mrserb

@mrserb This pull request is now open

openjdk[bot] avatar May 10 '24 01:05 openjdk[bot]

LGTM

bourgesl avatar May 10 '24 08:05 bourgesl

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 07 '24 09:06 bridgekeeper[bot]

keep open

mrserb avatar Jun 07 '24 18:06 mrserb

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 05 '24 19:07 bridgekeeper[bot]

keep open

mrserb avatar Jul 05 '24 19:07 mrserb

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 03 '24 00:08 bridgekeeper[bot]

keep open

mrserb avatar Aug 12 '24 17:08 mrserb

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 22 '24 21:08 openjdk[bot]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 09 '24 03:10 bridgekeeper[bot]

keep open

mrserb avatar Oct 12 '24 01:10 mrserb