jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8324587: @headful key is contained in ExceptionFromPrintableIsIgnoredTest.java

Open ktakakuri opened this issue 1 year ago • 7 comments

This fix removes the "@key headful printer" tag that was granted to ExceptionFromPrintableIsIgnoredTest.java in JDK-8273687. The test passed after this fix. Would you review this fix, please?


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8324587 needs maintainer approval

Issue

  • JDK-8324587: @headful key is contained in ExceptionFromPrintableIsIgnoredTest.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/425/head:pull/425
$ git checkout pull/425

Update a local copy of the PR:
$ git checkout pull/425
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 425

View PR using the GUI difftool:
$ git pr show -t 425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/425.diff

Webrev

Link to Webrev Comment

ktakakuri avatar Jan 24 '24 07:01 ktakakuri

:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jan 24 '24 07:01 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Jan 24 '24 07:01 mlbridge[bot]

How hard it will be backport the JDK-8185500?

mrserb avatar Jan 25 '24 00:01 mrserb

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Feb 22 '24 03:02 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 13 '24 20:03 openjdk[bot]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 11 '24 03:04 bridgekeeper[bot]

It appears that a pull request has already been issued for JDK-8185500. #464 I will close my pull request once it is merged.

ktakakuri avatar Apr 12 '24 12:04 ktakakuri

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 10 '24 17:05 bridgekeeper[bot]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Jun 07 '24 21:06 bridgekeeper[bot]

If there is a problem with #464 I will reopen this pull request.

ktakakuri avatar Jun 11 '24 08:06 ktakakuri