8263031: HttpClient throws Exception if it receives a Push Promise that is too large

[martinuy]

Hi,

Can I have a review for the backport of JDK-8263031 to 17u? This backport fixes a bug and will also serve as a dependency for a backport of 8328286.

The JDK main line patch did not apply cleanly because JDK-8295944 was backported to 17u already and tests were moved.

In addition, I had to make changes to PushPromiseContinuation.java to adapt the test to its new location (see jtreg header diff) and context (see the invocations to conn.addToOutputQ). With these changes, the test is passing.

No regressions observed in the jdk/java/net/httpclient tests category.

Thanks, Martin.-

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8263031 needs maintainer approval

Issue

• JDK-8263031: HttpClient throws Exception if it receives a Push Promise that is too large (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/400/head:pull/400
$ git checkout pull/400

Update a local copy of the PR:
$ git checkout pull/400
$ git pull https://git.openjdk.org/jdk17u.git pull/400/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 400

View PR using the GUI difftool:
$ git pr show -t 400

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/400.diff

Webrev

Link to Webrev Comment