jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8319567: Update java/lang/invoke tests to support vm flags

Open sendaoYan opened this issue 6 months ago • 5 comments

Hi all, This backport of https://github.com/openjdk/jdk/pull/16666 to jdk17u-dev, to make the test will support VM flags passed to jtreg, and a couple tests that ignore VM flags should use ProcessTools::createLimtiedTestJavaProcessBuilder and marks the test with @requires vm.flagless.

Addiontial testing:

  • [ ] linux x64 whole jtreg tests
  • [ ] linux aarch64 whole jtreg tests

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8319677 needs maintainer approval
  • [ ] JDK-8319568 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [ ] JDK-8319676 needs maintainer approval
  • [x] Commit message must refer to an issue
  • [ ] JDK-8319672 needs maintainer approval
  • [ ] JDK-8319567 needs maintainer approval

Issues

  • JDK-8319567: Update java/lang/invoke tests to support vm flags (Sub-task - P4)
  • JDK-8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags (Sub-task - P4)
  • JDK-8319672: Several classloader tests ignore VM flags (Sub-task - P4)
  • JDK-8319676: A couple of jdk/modules/incubator/ tests ignore VM flags (Sub-task - P4)
  • JDK-8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2817/head:pull/2817
$ git checkout pull/2817

Update a local copy of the PR:
$ git checkout pull/2817
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2817

View PR using the GUI difftool:
$ git pr show -t 2817

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2817.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Aug 21 '24 07:08 sendaoYan