jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8327474: Review use of java.io.tmpdir in jdk tests

Open sendaoYan opened this issue 6 months ago • 8 comments

Hi all,

This pull request contains a backport of commit af6c5854 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 22 Apr 2024 and had no reviewers.

The backport not clean because jdk17u-dev doesn't have test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java, all other files are backported cleanly. Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low.

Additional testing:

  • [x] full jtreg tests on linux x64
  • [x] full jtreg tests in linux aarch64

Thanks!


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] JDK-8327474 needs maintainer approval
  • [x] Commit message must refer to an issue

Issue

  • JDK-8327474: Review use of java.io.tmpdir in jdk tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2811/head:pull/2811
$ git checkout pull/2811

Update a local copy of the PR:
$ git checkout pull/2811
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2811

View PR using the GUI difftool:
$ git pr show -t 2811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2811.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Aug 16 '24 16:08 sendaoYan