jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8319569: Several java/util tests should be updated to accept VM flags

Open sendaoYan opened this issue 8 months ago • 6 comments

Hi all,

This pull request contains a backport of commit 2bb4b939 from the openjdk/jdk repository.

The commit being backported was authored by Justin Lu on 23 Nov 2023 and was reviewed by Naoto Sato and Lance Andersen.

There are two files make this backport not clean:

  1. jdk17u-dev doesn't have file test/jdk/java/util/Currency/PropertiesTest.sh
  2. test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java has previous change before the backport PR in jdk-tip

Additional testing

  • [ ] change verify

Thanks!


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8319569 needs maintainer approval

Issue

  • JDK-8319569: Several java/util tests should be updated to accept VM flags (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2620/head:pull/2620
$ git checkout pull/2620

Update a local copy of the PR:
$ git checkout pull/2620
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2620

View PR using the GUI difftool:
$ git pr show -t 2620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2620.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Jun 21 '24 01:06 sendaoYan