jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8331142: Add test for number of loader threads in BasicDirectoryModel

Open luchenlin opened this issue 1 year ago • 10 comments
trafficstars

I backport this for parity with 17.0.13-oracle. The test is limit to Windows, so backport with JDK-8331495 together.


Progress

  • [ ] JDK-8331495 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8331142 needs maintainer approval

Issues

  • JDK-8331142: Add test for number of loader threads in BasicDirectoryModel (Bug - P4)
  • JDK-8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only (Sub-task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2590/head:pull/2590
$ git checkout pull/2590

Update a local copy of the PR:
$ git checkout pull/2590
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2590

View PR using the GUI difftool:
$ git pr show -t 2590

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2590.diff

Webrev

Link to Webrev Comment

luchenlin avatar Jun 14 '24 09:06 luchenlin

:wave: Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 14 '24 09:06 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Jun 14 '24 09:06 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jun 14 '24 09:06 openjdk[bot]

/issue add JDK-8331495

luchenlin avatar Jun 14 '24 09:06 luchenlin

@luchenlin Adding additional issue to issue list: 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only.

openjdk[bot] avatar Jun 14 '24 09:06 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jun 14 '24 09:06 mlbridge[bot]

Please make it a backport from JDK 21 by changing the title: "Backport fcd7fb74c7654956660082c83e42d2262478a1e5".

TheRealMDoerr avatar Jun 17 '24 16:06 TheRealMDoerr

This backport pull request has now been updated with issues from the original commit.

openjdk[bot] avatar Jun 19 '24 09:06 openjdk[bot]

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jun 19 '24 09:06 openjdk[bot]

@luchenlin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 17 '24 14:07 bridgekeeper[bot]

@luchenlin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Aug 14 '24 14:08 bridgekeeper[bot]