jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC

Open zhengyu123 opened this issue 9 months ago • 5 comments

Backport this patch to jdk17u, as a prerequisite for clean backport of JDK-8328744, which is a p2 bug.


Progress

  • [x] Change must not contain extraneous whitespace
  • [ ] JDK-8319713 needs maintainer approval
  • [x] Commit message must refer to an issue

Issue

  • JDK-8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2450/head:pull/2450
$ git checkout pull/2450

Update a local copy of the PR:
$ git checkout pull/2450
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2450/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2450

View PR using the GUI difftool:
$ git pr show -t 2450

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2450.diff

Webrev

Link to Webrev Comment

zhengyu123 avatar May 07 '24 16:05 zhengyu123

:wave: Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 07 '24 17:05 bridgekeeper[bot]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • 1ead7a7fdeb6ddbbe3ad0896b7d492929ef9b7a3: 8331265: Bump update version for OpenJDK: jdk-17.0.13
  • c9d83d392f3809bf536afdcb52142ee6916acff0: 8325203: System.exit(0) kills the launched 3rd party application
  • 0cfee92c2974aaf8fe387e3393702e58c2917f18: 8294699: Launcher causes lingering busy cursor
  • f4da0e7a58261a25ca11783c62f4a6f53718103e: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • d1e31f6f6a455572c2d5b6f118ce54fa040e0e82: 8289643: File descriptor leak with ProcessBuilder.startPipeline
  • 69e67363d784d90dc259cd1aeb383f5c72a724b9: 8314835: gtest wrappers should be marked as flagless
  • 6c3a188d47aa738bf8faaabb10fb56b4989fc1cb: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS
  • 060c2504c90318cdc3582204fd88a664c58dd9fd: 8177107: Reduce memory footprint of java.lang.reflect.Constructor/Method
  • 4071b8c9be8e763d48bab1a5b8d57729a4f1307b: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
  • a64000108dc775574ddf8cbbcdc9cfa3975bcdde: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • ... and 30 more: https://git.openjdk.org/jdk17u-dev/compare/d2982c673053bdea8bc122230a4d57eda76832ef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 07 '24 17:05 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar May 07 '24 17:05 openjdk[bot]

⚠️ @zhengyu123 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar May 07 '24 17:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 07 '24 17:05 mlbridge[bot]

/integrate

Approved

zhengyu123 avatar May 31 '24 00:05 zhengyu123

Going to push as commit 7a8cf6c8aec6cd648663def62d9496e516f05d4f. Since your change was applied there have been 48 commits pushed to the master branch:

  • 515bc9a264c1e44cfcada0405a74ab2fba428e10: 8318986: Improve GenericWaitBarrier performance
  • dcb2c35151a846b7c44045235b389baf9713885c: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • 8faeefc1509a5b890bdae852472c318c64dc0772: 8289182: NMT: MemTracker::baseline should return void
  • e85eecbea09e68fcac68a39901a58ddf41fa9dbd: 8288568: Reduce runtime of java.security microbenchmarks
  • 2d834b36ec68890befc21d93b667d07cbf3c007a: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
  • 787cf27a8bb19c58bfa5bd17bf433ddaa99117d7: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"
  • 24aa1e1f1835c83cbf5cfeda56186511a3bd0100: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
  • cc3f0e52bfee9d96c464ae55999e834717aa3772: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader
  • 1ead7a7fdeb6ddbbe3ad0896b7d492929ef9b7a3: 8331265: Bump update version for OpenJDK: jdk-17.0.13
  • c9d83d392f3809bf536afdcb52142ee6916acff0: 8325203: System.exit(0) kills the launched 3rd party application
  • ... and 38 more: https://git.openjdk.org/jdk17u-dev/compare/d2982c673053bdea8bc122230a4d57eda76832ef...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 31 '24 00:05 openjdk[bot]

@zhengyu123 Pushed as commit 7a8cf6c8aec6cd648663def62d9496e516f05d4f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 31 '24 00:05 openjdk[bot]