8272315: Improve assert_different_registers

[TheRealMDoerr]

Clean backport of JDK-8272315. It's only an enhancement, but it is required for other changes. E.g. the "Represent Registers as values" changes which were done for GCC 11 support like JDK-8297445 don't build without it: no known conversion for argument 1 from 'Register' to 'AbstractRegister' {aka 'AbstractRegisterImpl*'}

---

Progress

• [ ] JDK-8272315 needs maintainer approval
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8272315: Improve assert_different_registers (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2448/head:pull/2448
$ git checkout pull/2448

Update a local copy of the PR:
$ git checkout pull/2448
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2448

View PR using the GUI difftool:
$ git pr show -t 2448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2448.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272315: Improve assert_different_registers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[openjdk[bot]]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge[bot]]

Webrevs

• 00: Full (5f021f84)

[TheRealMDoerr]

GHA test failure is unrelated.

[TheRealMDoerr]

/approval request This is an enhancement, but it is required for other changes to work. It is more generic and helps future backports. E.g. the "Represent Registers as values" changes which were done for GCC 11 support like JDK-8297445 don't build without it: "no known conversion for argument 1 from 'Register' to 'AbstractRegister' {aka 'AbstractRegisterImpl*'}". Risk is low because the new code is used for debug builds only. It applies cleanly and our nightly testing has passed.

[openjdk[bot]]

@TheRealMDoerr 8272315: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk[bot]]

Going to push as commit 5a3c668646c363f2a2028e4aede63eef524ad5fd. Since your change was applied there has been 1 commit pushed to the master branch:

• e97489774f0b893ed173be05e5d848ee2af76775: 8298413: [s390] CPUInfoTest fails due to uppercase feature string

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@TheRealMDoerr Pushed as commit 5a3c668646c363f2a2028e4aede63eef524ad5fd.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.