jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8297878: KEM: Implementation

Open wangweij opened this issue 9 months ago • 4 comments

The src change is identical to the one in JDK 17u MR1 at https://github.com/openjdk/jdk17u-ri/commit/e9d2641a14407380264b50fa2fe299980fe5f214. There RSA_KEM.java test is also identical. There is no Proc.java related change here since it was only used by Oracle's internal interop tests.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [ ] JDK-8322971 needs maintainer approval
  • [x] Commit message must refer to an issue
  • [ ] JDK-8297878 needs maintainer approval

Issues

  • JDK-8297878: KEM: Implementation (Enhancement - P3) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.
  • JDK-8322971: KEM.getInstance() should check if a 3rd-party security provider is signed (Bug - P3) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2443/head:pull/2443
$ git checkout pull/2443

Update a local copy of the PR:
$ git checkout pull/2443
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2443/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2443

View PR using the GUI difftool:
$ git pr show -t 2443

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2443.diff

wangweij avatar May 01 '24 23:05 wangweij

:wave: Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 01 '24 23:05 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar May 01 '24 23:05 openjdk[bot]

/issue add JDK-8322971

wangweij avatar May 01 '24 23:05 wangweij

@wangweij Adding additional issue to issue list: 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed.

openjdk[bot] avatar May 01 '24 23:05 openjdk[bot]