jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

Open sendaoYan opened this issue 10 months ago • 7 comments

Hi,

Clean backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

image

Thanks, -sendao


Progress

  • [x] JDK-8321925 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2342/head:pull/2342
$ git checkout pull/2342

Update a local copy of the PR:
$ git checkout pull/2342
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2342

View PR using the GUI difftool:
$ git pr show -t 2342

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2342.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Mar 28 '24 03:03 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 28 '24 03:03 bridgekeeper[bot]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Mar 28 '24 03:03 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Mar 28 '24 03:03 openjdk[bot]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Mar 28 '24 03:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 28 '24 03:03 mlbridge[bot]

/approval request Clean backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

sendaoYan avatar Apr 07 '24 01:04 sendaoYan

@sendaoYan 8321925: The approval request has been created successfully.

openjdk[bot] avatar Apr 07 '24 01:04 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 09 '24 00:05 bridgekeeper[bot]

/approval request Clean backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

sendaoYan avatar May 09 '24 02:05 sendaoYan

@sendaoYan 8321925: Approval has already been requested and approved.

openjdk[bot] avatar May 09 '24 02:05 openjdk[bot]

/integrate

sendaoYan avatar May 13 '24 09:05 sendaoYan

@sendaoYan Your change (at version dfa99758ddfdca4cde85382cf5dbf726caaa8bf0) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 13 '24 09:05 openjdk[bot]

/sponsor

TheRealMDoerr avatar May 13 '24 12:05 TheRealMDoerr

Going to push as commit bf4b15ce080bfdf1dd818233cd1ef6ac0519294d. Since your change was applied there have been 3 commits pushed to the master branch:

  • ce1fb0265b3edf904ea00b190957e8a70371a080: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • 606c542e7f9cb629e030463f07994e665f6212a2: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 16579f8658b6422131dd3ca35e7276eb6c477c12: 8297445: PPC64: Represent Registers as values

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 13 '24 12:05 openjdk[bot]

@TheRealMDoerr @sendaoYan Pushed as commit bf4b15ce080bfdf1dd818233cd1ef6ac0519294d.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 13 '24 12:05 openjdk[bot]

/sponsor

Thanks.

sendaoYan avatar May 13 '24 12:05 sendaoYan