jdk17u-dev
jdk17u-dev copied to clipboard
openjdk
8325567: jspawnhelper without args fails with segfault
Clean backport.Testing is in progress
Progress
- [x] Change must not contain extraneous whitespace
- [ ] JDK-8325567 needs maintainer approval
- [x] Commit message must refer to an issue
Issue
- JDK-8325567: jspawnhelper without args fails with segfault (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2339/head:pull/2339
$ git checkout pull/2339
Update a local copy of the PR:
$ git checkout pull/2339
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2339/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2339
View PR using the GUI difftool:
$ git pr show -t 2339
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2339.diff
Webrev
:wave: Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@elifaslan1 This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8325567: jspawnhelper without args fails with segfault
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 7 new commits pushed to the master branch:
- a86a221d6d8c0f6db5f7bfbed4fb839b242cf381: 8329995: Restricted access to
/proccan cause JFR initialization to crash - 28aa19e68779cc1209b712bbaf3e54b26f874b9c: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
- 9aa7b2f8f12968a282effcf46f15abfb51e187ca: 8279337: The MToolkit is still referenced in a few places
- 2db15017683a4b72798439c39e96038d0ca9c4fe: 8323801:
tag doesn't strikethrough the text - 53774581d3c67a0366c582f895ba86e5255bbdb7: 8005885: enhance PrintCodeCache to print more data
- d23f4d6618b8326a9974b214aeee10a4450a5b6f: 8282526: Default icon is not painted properly
- d117806dd0f4a651ac3264f81b8cf8d98db89b98: 8279068: IGV: Update to work with JDK 16 and 17
Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
@elifaslan1 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
The test does not work reliably, because JDK-8233725 bugfix is missing. I'll look into backporting that one first.
Here is the backport PR: https://github.com/openjdk/jdk17u-dev/pull/2456
/approval request Clean backport to address the segmentation fault issue that occurs when jspawnhelper is called without arguments. There is a new test added to verify the behavior in such cases.New regression test fails without the fix, and passes with the change.
:warning: @elifaslan1 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:
$ git checkout JDK-8325567
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push
@elifaslan1 Your change (at version beaac6f77759f2a8b691b0192effa97f06572921) is now ready to be sponsored by a Committer.
Going to push as commit af699ffaf539dd2ab93561d973af7b2b783ab6c5.
Since your change was applied there have been 7 commits pushed to the master branch:
- a86a221d6d8c0f6db5f7bfbed4fb839b242cf381: 8329995: Restricted access to
/proccan cause JFR initialization to crash - 28aa19e68779cc1209b712bbaf3e54b26f874b9c: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
- 9aa7b2f8f12968a282effcf46f15abfb51e187ca: 8279337: The MToolkit is still referenced in a few places
- 2db15017683a4b72798439c39e96038d0ca9c4fe: 8323801:
tag doesn't strikethrough the text - 53774581d3c67a0366c582f895ba86e5255bbdb7: 8005885: enhance PrintCodeCache to print more data
- d23f4d6618b8326a9974b214aeee10a4450a5b6f: 8282526: Default icon is not painted properly
- d117806dd0f4a651ac3264f81b8cf8d98db89b98: 8279068: IGV: Update to work with JDK 16 and 17
Your commit was automatically rebased without conflicts.
@shipilev @elifaslan1 Pushed as commit af699ffaf539dd2ab93561d973af7b2b783ab6c5.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.