jdk17u-dev
jdk17u-dev copied to clipboard
8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
Hi,
Clean backport of JDK-8311964. Backport has been verified as bellow. Only change the testcases, the risk is low.
There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags. test command:
rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option"
Thanks, -sendao
After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client.
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [x] JDK-8311964 needs maintainer approval
Issue
- JDK-8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) (Bug - P4 - Approved)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2216/head:pull/2216
$ git checkout pull/2216
Update a local copy of the PR:
$ git checkout pull/2216
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2216/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2216
View PR using the GUI difftool:
$ git pr show -t 2216
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2216.diff
Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
This backport pull request has now been updated with issue from the original commit.
⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval JDK-8311964 request
@sendaoYan JDK-8311964: The approval request has been created successfully.
@sendaoYan This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the master
branch. If another commit should be pushed before you perform the /integrate
command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate
in a new comment. (Afterwards, your sponsor types /sponsor
in a new comment to perform the integration).
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval JDK-8311964 request "Clean backport. Backport has been verified. Only change the testcases, the risk is low."
@sendaoYan JDK-8311964: The approval request has been updated successfully.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval JDK-8311964 request "Clean backport. Backport has been verified. Only change the testcases, the risk is low."
@sendaoYan JDK-8311964: Approval has already been requested and approved.
/integrate
@sendaoYan Your change (at version f7041a6788e26aed05b80e6de19ccfb43431c03d) is now ready to be sponsored by a Committer.
Same thing here: please merge from current master to get an up-to-date test run.
Same thing here: please merge from current master to get an up-to-date test run.
Thanks, I will check all mine PRs right now.
/integrate
@sendaoYan Your change (at version a6523b69d4e650ecffa9ad279870d9f62de27e26) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit ce1fb0265b3edf904ea00b190957e8a70371a080.
Since your change was applied there have been 2 commits pushed to the master
branch:
- 606c542e7f9cb629e030463f07994e665f6212a2: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
- 16579f8658b6422131dd3ca35e7276eb6c477c12: 8297445: PPC64: Represent Registers as values
Your commit was automatically rebased without conflicts.
@TheRealMDoerr @sendaoYan Pushed as commit ce1fb0265b3edf904ea00b190957e8a70371a080.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
/sponsor
Thanks.