jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978

Open sendaoYan opened this issue 1 year ago • 9 comments

Hi,

The testcase ReflectionCallerCacheTest.java run failed with -Xcomp, both on linux-x86_64 and linux-aarch64.

And it run pass by jdk23 binary with the same testcase and the same jvm options(-Xcomp):

image

Before we found the root cause of this failure, should we problem list this testcase in test/jdk/ProblemList-Xcomp.txt.

Thanks, -sendao


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8327312 needs maintainer approval

Issue

  • JDK-8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978 (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2186/head:pull/2186
$ git checkout pull/2186

Update a local copy of the PR:
$ git checkout pull/2186
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2186

View PR using the GUI difftool:
$ git pr show -t 2186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2186.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Jan 30 '24 16:01 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jan 30 '24 16:01 bridgekeeper[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Feb 27 '24 20:02 bridgekeeper[bot]

@sendaoYan 8327312: The approval request has been created successfully.

openjdk[bot] avatar Mar 05 '24 09:03 openjdk[bot]

@sendaoYan 8327312: The approval request has been cancelled successfully.

openjdk[bot] avatar Mar 07 '24 03:03 openjdk[bot]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327312: [17u] Problem list ReflectionCallerCacheTest.java due to 8324978

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 2ec87177d436f8f97dc3358d4ad1355e7c4b6a26: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • 772c9786bd0954b93dfac4f89d92f3fc362bb444: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message
  • 68193818b51e190425a34e26d6368b3cb8e3c296: 8280988: [XWayland] Click on title to request focus test failures
  • 15c5caa2f72a5c7581649b0fd8a71c3502a2972f: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 4650ece6c987b1291c723feb72a136ca94fe482f: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • a15f35d33587e57cc294734f04c7fa119b0b73c1: 8298381: Improve handling of session tickets for multiple SSLContexts
  • c32a56fc69602db954d4bdf0e986037fab6f0951: 8331077: nroff man page update for jar tool
  • f4e81948c0d91cc43e2aa6453cda9892ed60db10: 8324753: [AIX] adjust os_posix after JDK-8318696
  • efee05f404f0d8a6b03f203a13d48ad6177bc828: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
  • 5ed58c2fe40a7dfab39c3fcf363fc5e44413b2de: 8326332: Unclosed inline tags cause misalignment in summary tables
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/933587a015519fd12a458d19ab214182e35366a8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Mar 13 '24 19:03 openjdk[bot]

Problem list this fail testcase to test/jdk/ProblemList-Xcomp.txt, the risk is low. Can anyone review this PR, thanks.

sendaoYan avatar Mar 14 '24 01:03 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 11 '24 04:04 bridgekeeper[bot]

Problem list this fail testcase to test/jdk/ProblemList-Xcomp.txt, the risk is low. Can anyone review this PR, thanks.

sendaoYan avatar Apr 11 '24 06:04 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 09 '24 11:05 bridgekeeper[bot]

Hi, Problem list this fail testcase to test/jdk/ProblemList-Xcomp.txt, no risk. Can anyone review this PR, thanks.

sendaoYan avatar May 09 '24 12:05 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 25 '24 04:06 bridgekeeper[bot]

Hi, Problem list this fail testcase to test/jdk/ProblemList-Xcomp.txt, no risk. Can anyone review this PR, thanks.

sendaoYan avatar Jun 25 '24 06:06 sendaoYan

The GHA test runner report a failure wget exited with exit code 4, it seems like a environmental issue, ununrelated to this PR.

sendaoYan avatar Jun 25 '24 09:06 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 23 '24 14:07 bridgekeeper[bot]

/approval request Problemlist failed testcase in test/jdk/ProblemList-Xcomp.txt, make less noisy in CI.

sendaoYan avatar Jul 24 '24 11:07 sendaoYan

@sendaoYan 8327312: The approval request has been created successfully.

openjdk[bot] avatar Jul 24 '24 11:07 openjdk[bot]

What happens in jdk21u? Does the problem exist there as well?

RealCLanger avatar Jul 26 '24 06:07 RealCLanger

We can reproduce the failure, so the exclusion seems ok.

RealCLanger avatar Aug 01 '24 08:08 RealCLanger

Thanks all for the review.

sendaoYan avatar Aug 01 '24 09:08 sendaoYan

Thanks for the approved. /integrate

sendaoYan avatar Aug 02 '24 08:08 sendaoYan

@sendaoYan Your change (at version 8d0d48963a61173b0eea9a0a890ed7d3984650d4) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Aug 02 '24 08:08 openjdk[bot]

/sponsor

RealCLanger avatar Aug 02 '24 11:08 RealCLanger

Going to push as commit 9ca66081d5f92b63cb3d4116468f256c4d3f14b3. Since your change was applied there have been 24 commits pushed to the master branch:

  • 8f32625b1181e193d9b529111bfce9f5d4d626b9: 8333270: HandlersOnComplexResetUpdate and HandlersOnComplexUpdate tests fail with "Unexpected reference" if timeoutFactor is less than 1/3
  • 4d03e9ddc957bb08f405367f0d8b9a0748ef170e: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
  • a76c3af69f59ff2d7881c29f9f478ecfadfe23d5: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 8bb51e5edb0e3a4a3e32076966b81eaf20903ed4: 8317635: Improve GetClassFields test to verify correctness of field order
  • 10000286390ac9b0288cee25a4f3551d09475fdc: 8292044: HttpClient doesn't handle 102 or 103 properly
  • 2ec87177d436f8f97dc3358d4ad1355e7c4b6a26: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • 772c9786bd0954b93dfac4f89d92f3fc362bb444: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message
  • 68193818b51e190425a34e26d6368b3cb8e3c296: 8280988: [XWayland] Click on title to request focus test failures
  • 15c5caa2f72a5c7581649b0fd8a71c3502a2972f: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 4650ece6c987b1291c723feb72a136ca94fe482f: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • ... and 14 more: https://git.openjdk.org/jdk17u-dev/compare/933587a015519fd12a458d19ab214182e35366a8...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 02 '24 11:08 openjdk[bot]

@RealCLanger @sendaoYan Pushed as commit 9ca66081d5f92b63cb3d4116468f256c4d3f14b3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 02 '24 11:08 openjdk[bot]

Thanks for the sponsor.

sendaoYan avatar Aug 02 '24 12:08 sendaoYan