jdk16u icon indicating copy to clipboard operation
jdk16u copied to clipboard

8268127: Shenandoah: Heap size may be too small for region to align to large page size

Open zhengyu123 opened this issue 3 years ago • 4 comments

I would like to backport this Shenandoah specific patch to 16u, which allows to fallback to regular pages for regions, if heap size is too small to allow regions to use large pages.

The original patch does not apply cleanly, resolved then manually.

Test: Manually test to ensure large pages are used. Failed w/o the patch and passed with it.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] Change must be properly reviewed

Issue

  • JDK-8268127: Shenandoah: Heap size may be too small for region to align to large page size

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/128/head:pull/128
$ git checkout pull/128

Update a local copy of the PR:
$ git checkout pull/128
$ git pull https://git.openjdk.java.net/jdk16u pull/128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 128

View PR using the GUI difftool:
$ git pr show -t 128

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/128.diff

zhengyu123 avatar Jun 11 '21 14:06 zhengyu123

:wave: Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 11 '21 14:06 bridgekeeper[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jun 11 '21 14:06 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jun 11 '21 14:06 mlbridge[bot]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268127: Shenandoah: Heap size may be too small for region to align to large page size

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 7dcedb672b0e134410954e145483fecbbbd3754d: Merge
  • 3b56f0b15cee132d6366e8ec03e05c918a42b4f1: Merge
  • b3b4dc32a67b77666b5c81ab73830f4ad82892ea: 8268173: Wrong GA date in JDK 11.0.12 and 16.0.2 versions
  • b609c519ef7df866d4412e79e4a71fe1bd051473: Merge
  • 6fc68c2fbb32c9c9cc817187415ffc25eb2e85db: Merge
  • 9a4b6db45f760bfdfa8e0c1d38718cd0d927eb17: Merge
  • c44d5173266e599c362dd6975942dcd5bcd6afe3: Merge branch 'jdk16.0.2' into 'jdk16.0.2'
  • 0a52d016b863595baeab003623a8ee2ab5a481c2: 8266205: Update milestone to fcs for jdk16.0.2+4
  • ee4633de70c884d1e16ff7b602d21b252c1de501: Merge
  • 6d8f828dd6de9ca443c9e2192c9d99bf7eb15264: Merge
  • ... and 32 more: https://git.openjdk.java.net/jdk16u/compare/d2d95335667758c5be7a7f3d8150f8556b869dac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Sep 14 '21 20:09 openjdk[bot]