jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8348598: Update Libpng to 1.6.47

Open vieiro opened this issue 7 months ago • 4 comments
trafficstars

Backport of JDK-8348598 from JDK-17.

Not clean as make/lib/Awt2dLibraries.gmk is different from JDK-17. Resolved adding the new unused-function to gccand gclang disabled warnings for AWT libraries.

Tier 1 tests pass. Tests for javax.imageio and java2d/cmm pass. jfc_demo is great to see! :-) .

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/javax/imageio                        197   197     0     0   
==============================
TEST SUCCESS


==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/sun/java2d/cmm                        19    19     0     0   
==============================
TEST SUCCESS

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk:jfc_demo                               1     1     0     0   
==============================
TEST SUCCESS

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8348598 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3021/head:pull/3021
$ git checkout pull/3021

Update a local copy of the PR:
$ git checkout pull/3021
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3021/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3021

View PR using the GUI difftool:
$ git pr show -t 3021

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3021.diff

Using Webrev

Link to Webrev Comment

vieiro avatar Apr 03 '25 07:04 vieiro

:wave: Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 03 '25 07:04 bridgekeeper[bot]

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8348598: Update Libpng to 1.6.47

Reviewed-by: sgehwolf, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 398ba91d4d0cfbc737992a8414a7bec13fc10182: 8348110: Update LCMS to 2.17
  • 276a157622f76d7210e11423879d81ccd70c3568: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • 524170d5a03c9df2ca463ed416e786a4b412ed6c: Merge
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/657f3cd3e5dea5dead60db45e9e168f8ed0e0b65...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Apr 03 '25 07:04 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Apr 03 '25 07:04 openjdk[bot]

Webrevs

mlbridge[bot] avatar Apr 03 '25 07:04 mlbridge[bot]

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 01 '25 12:05 bridgekeeper[bot]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar May 08 '25 09:05 openjdk[bot]

/approval request Please approve this backport from JDK 17 that improves colorspace handling and includes other fixes http://www.libpng.org/pub/png/src/libpng-1.6.47-README.txt

vieiro avatar May 08 '25 10:05 vieiro

@vieiro 8348598: The approval request has been created successfully.

openjdk[bot] avatar May 08 '25 10:05 openjdk[bot]

/integrate

vieiro avatar May 08 '25 17:05 vieiro

@vieiro Your change (at version 34e5e70c153b8e918923f7d41531dddd5b95e83e) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 08 '25 18:05 openjdk[bot]

/sponsor

gnu-andrew avatar May 08 '25 20:05 gnu-andrew

Going to push as commit 61227856ccd28d887d56d0c93eabd07cf6b026d3. Since your change was applied there have been 18 commits pushed to the master branch:

  • 398ba91d4d0cfbc737992a8414a7bec13fc10182: 8348110: Update LCMS to 2.17
  • 276a157622f76d7210e11423879d81ccd70c3568: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • 524170d5a03c9df2ca463ed416e786a4b412ed6c: Merge
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/657f3cd3e5dea5dead60db45e9e168f8ed0e0b65...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 08 '25 20:05 openjdk[bot]

@gnu-andrew @vieiro Pushed as commit 61227856ccd28d887d56d0c93eabd07cf6b026d3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 08 '25 20:05 openjdk[bot]