jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8328379: Convert URLDragTest.html applet test to main

Open toshiogata opened this issue 9 months ago • 16 comments

Hi all,

I would like to backport this patch to improve test maintainability. The patch is not clean. A text block needs to be replaced with string literals. Testing: manually checked URLDragTest.java, and confirmed that the test works in the same way.

Thank you.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8328379 needs maintainer approval

Issue

  • JDK-8328379: Convert URLDragTest.html applet test to main (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3002/head:pull/3002
$ git checkout pull/3002

Update a local copy of the PR:
$ git checkout pull/3002
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3002

View PR using the GUI difftool:
$ git pr show -t 3002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3002.diff

Using Webrev

Link to Webrev Comment

toshiogata avatar Feb 26 '25 07:02 toshiogata

:wave: Welcome back toshiogata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 26 '25 07:02 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Feb 26 '25 07:02 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Feb 26 '25 07:02 openjdk[bot]

GHA report 1 test failure on macos-x64

  • serviceability/sa/ClhsdbFindPC.java#id1

This test failure occurs frequently in recent GHA runs, and is not related to this fix. Perhaps related issue for this failure is https://bugs.openjdk.org/browse/JDK-8253028

toshiogata avatar Feb 26 '25 07:02 toshiogata

@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 26 '25 10:03 bridgekeeper[bot]

Keep open. After merging the latest source, GHA reports no test failure.

toshiogata avatar Apr 17 '25 07:04 toshiogata

@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 15 '25 12:05 bridgekeeper[bot]

Keep open.

Additional comments for this PR This PR can make the backport of JDK-8337851 (https://bugs.openjdk.org/browse/JDK-8337851) cleaner.

toshiogata avatar Jun 10 '25 10:06 toshiogata

@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 08 '25 12:07 bridgekeeper[bot]

/touch

toshiogata avatar Aug 03 '25 23:08 toshiogata

@toshiogata The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Aug 03 '25 23:08 openjdk[bot]

@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 04 '25 05:09 bridgekeeper[bot]

/touch

toshiogata avatar Sep 25 '25 05:09 toshiogata

@toshiogata The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Sep 25 '25 05:09 openjdk[bot]

@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 23 '25 14:10 bridgekeeper[bot]