jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8299254: Support dealing with standard assert macro

Open vieiro opened this issue 5 months ago • 9 comments

Backport of JDK-8299254 Support dealing with standard assert macro on top of the previous PR macos-12 github actions .

This will make the github actions in jdk11u-dev run again on top of macos-12 / xcode-13.4.1 .

The change is minimal, and should work properly with no changes on any existing macos-11 CI pipelines.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8299254 needs maintainer approval

Issue

  • JDK-8299254: Support dealing with standard assert macro (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2937/head:pull/2937
$ git checkout pull/2937

Update a local copy of the PR:
$ git checkout pull/2937
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2937/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2937

View PR using the GUI difftool:
$ git pr show -t 2937

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2937.diff

Webrev

Link to Webrev Comment

vieiro avatar Sep 19 '24 09:09 vieiro