jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8232367: Update Reactive Streams to 1.0.3 -- tests only

Open amosshi opened this issue 1 year ago • 7 comments

Backport of JDK-8232367

Testing

  • Local: Compile passed on MacOS 14.6.1 on Apple M1 Max
    • Not a test or directory containing tests: java/net/httpclient/reactivestreams-tck/org/reactivestreams/tck/SubscriberWhiteboxVerification.java
  • Pipeline: All passed except macOS
    • macOS: /Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here The issue exists in all recent PR in jdk11u-dev and not caused by Current PR
  • Testing Machine: We consider SAP nightlies passed on 2024-09-03
    • Because no test failure is found caused by SubscriberWhiteboxVerification.java

Progress

  • [x] Change must not contain extraneous whitespace
  • [ ] JDK-8232367 needs maintainer approval
  • [x] Commit message must refer to an issue

Issue

  • JDK-8232367: Update Reactive Streams to 1.0.3 -- tests only (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2921/head:pull/2921
$ git checkout pull/2921

Update a local copy of the PR:
$ git checkout pull/2921
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2921/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2921

View PR using the GUI difftool:
$ git pr show -t 2921

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2921.diff

Webrev

Link to Webrev Comment

amosshi avatar Aug 24 '24 03:08 amosshi

:wave: Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 24 '24 03:08 bridgekeeper[bot]

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8232367: Update Reactive Streams to 1.0.3 -- tests only

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 98161b7a9b1ff4a9f3b6c41efd15c31a8f959c68: 8334332: TestIOException.java fails if run by root
  • 9bf55020f074e77df170d7f5bbf807db3a183232: 8342426: [11u] javax/naming/module/RunBasic.java javac compile fails
  • 8ba0341757545856666fbfcd3e7f9d715f5c0f86: Merge
  • cee8535a9d3de8558b4b5028d68e397e508bef71: 8341675: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.25
  • 86d5188b8939c05abc2340c4c389c5fca640c485: 8332644: Improve graph optimizations
  • 34a77a471b260f3b6f65c6cc61609d51eeade193: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property
  • eb960ff6d44af11a38f88a20db68218343725c7b: 8251188: Update LDAP tests not to use wildcard addresses
  • bd85b8729d9c7ffb31c57f328f35f4391b7d72fe: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
  • 56ded02fd8bcc61399b3ca5091d6e597759fb30e: 8331446: Improve deserialization support
  • 51657d990a40aed8f197bad24160765dde0a1f82: 8328726: Better Kerberos support
  • ... and 32 more: https://git.openjdk.org/jdk11u-dev/compare/828d645208f490b8a74d5e007d37bad7dcad50b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 24 '24 03:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 24 '24 03:08 openjdk[bot]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 24 '24 03:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 24 '24 03:08 mlbridge[bot]

/approval request "Backporting for parity with 11.0.25-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-09-03”

amosshi avatar Sep 05 '24 19:09 amosshi

@amosshi 8232367: The approval request has been created successfully.

openjdk[bot] avatar Sep 05 '24 19:09 openjdk[bot]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 03 '24 23:10 bridgekeeper[bot]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 30 '24 22:10 bridgekeeper[bot]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '24 04:10 bridgekeeper[bot]

@amosshi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '24 10:10 bridgekeeper[bot]

/integrate

amosshi avatar Nov 11 '24 05:11 amosshi

Going to push as commit add90003d601eec60cf9166f6013f0e86382729d. Since your change was applied there have been 44 commits pushed to the master branch:

  • 827528c3228705496813887f92f964310b010464: 8339470: [17u] More defensive fix for 8163921
  • 96805ae97b5153b48d5fa5d1dac99a3763f9cde9: 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts
  • 98161b7a9b1ff4a9f3b6c41efd15c31a8f959c68: 8334332: TestIOException.java fails if run by root
  • 9bf55020f074e77df170d7f5bbf807db3a183232: 8342426: [11u] javax/naming/module/RunBasic.java javac compile fails
  • 8ba0341757545856666fbfcd3e7f9d715f5c0f86: Merge
  • cee8535a9d3de8558b4b5028d68e397e508bef71: 8341675: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.25
  • 86d5188b8939c05abc2340c4c389c5fca640c485: 8332644: Improve graph optimizations
  • 34a77a471b260f3b6f65c6cc61609d51eeade193: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property
  • eb960ff6d44af11a38f88a20db68218343725c7b: 8251188: Update LDAP tests not to use wildcard addresses
  • bd85b8729d9c7ffb31c57f328f35f4391b7d72fe: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
  • ... and 34 more: https://git.openjdk.org/jdk11u-dev/compare/828d645208f490b8a74d5e007d37bad7dcad50b1...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Nov 11 '24 05:11 openjdk[bot]

@amosshi Pushed as commit add90003d601eec60cf9166f6013f0e86382729d.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Nov 11 '24 05:11 openjdk[bot]

/integrate

amosshi avatar Nov 11 '24 05:11 amosshi

@amosshi The command integrate can only be used in open pull requests.

openjdk[bot] avatar Nov 11 '24 05:11 openjdk[bot]