jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8317343: GC: Make TestHeapFreeRatio use createTestJvm

Open luchenlin opened this issue 1 year ago • 5 comments

I backport this for parity with 11.0.25-oracle.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] JDK-8317343 needs maintainer approval

Issue

  • JDK-8317343: GC: Make TestHeapFreeRatio use createTestJvm (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2893/head:pull/2893
$ git checkout pull/2893

Update a local copy of the PR:
$ git checkout pull/2893
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2893/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2893

View PR using the GUI difftool:
$ git pr show -t 2893

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2893.diff

Webrev

Link to Webrev Comment

luchenlin avatar Aug 01 '24 08:08 luchenlin

:wave: Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 01 '24 08:08 bridgekeeper[bot]

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8317343: GC: Make TestHeapFreeRatio use createTestJvm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 8ef848219bc270b968ca5e9ecdd371973f2debb3: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java
  • 7547abf0d3005b9d82b49fc1e6455eb30183d3bb: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • ee57792bbae576eeaff1c95873ade2d529d514ce: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
  • d668844b6622b61cca05fd303c461295f9ca6e10: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 01 '24 08:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 01 '24 08:08 openjdk[bot]

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 01 '24 08:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 01 '24 08:08 mlbridge[bot]

/integrate

luchenlin avatar Aug 05 '24 02:08 luchenlin

Going to push as commit 1daafddfd02f1e01a46bf1228877f6f261ce4c24. Since your change was applied there have been 4 commits pushed to the master branch:

  • 8ef848219bc270b968ca5e9ecdd371973f2debb3: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java
  • 7547abf0d3005b9d82b49fc1e6455eb30183d3bb: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • ee57792bbae576eeaff1c95873ade2d529d514ce: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
  • d668844b6622b61cca05fd303c461295f9ca6e10: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 05 '24 02:08 openjdk[bot]

@luchenlin Pushed as commit 1daafddfd02f1e01a46bf1228877f6f261ce4c24.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 05 '24 02:08 openjdk[bot]