jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8336292: [11u] awt_ImagingLib passes arguments to function without a prototype

Open vieiro opened this issue 7 months ago • 4 comments

This is a fix to JDK-8336292: Building 11u on the latest macos-13 GHA platform (XCode 14, clang 14) fails as we are passing arguments to a function without a prototype in awt_ImagingLib.c.

The fix adds disables the deprecated-non-prototype when building with clang, for the build to pass.

This is a 11u only issue, as the make infrastructure was reorganized in JDK-8244044 after OpenJDK 15, and enhanced afterwards. Backporting JDK-8244044 is an important change that should be avoided unless strictly necessary.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [ ] JDK-8336292 needs maintainer approval
  • [x] Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #2853 must be integrated first

Issue

  • JDK-8336292: [11u] awt_ImagingLib passes arguments to function without a prototype (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2854/head:pull/2854
$ git checkout pull/2854

Update a local copy of the PR:
$ git checkout pull/2854
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2854

View PR using the GUI difftool:
$ git pr show -t 2854

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2854.diff

Webrev

Link to Webrev Comment

vieiro avatar Jul 12 '24 07:07 vieiro