jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop

Open vieiro opened this issue 1 year ago • 6 comments

Backport of JDK-8272973.

Parity with 11.0.25-oracle.

Test passes in both release and fastdebug mode with private static final int iter = 10_000;

But with private static final int iter = 20_000; the test passes in release mode, but fails in fastdebug mode with assert(n->req() == 2 && n->in(1) != __null) failed: Only one data input expected:

# To suppress the following error report, specify this argument
# after -XX: or in .hotspotrc:  SuppressErrorAt=/cfgnode.cpp:621
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/home/avieirov/REPOS/OPENJDK/jdk11u-dev/src/hotspot/share/opto/cfgnode.cpp:621), pid=1641259, tid=1641275
#  assert(n->req() == 2 && n->in(1) != __null) failed: Only one data input expected
#
# JRE version: OpenJDK Runtime Environment (11.0.25) (fastdebug build 11.0.25-internal+0-adhoc.avieirov.jdk11u-dev)
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 11.0.25-internal+0-adhoc.avieirov.jdk11u-dev, mixed mode, compressed oops, g1 gc, linux-amd64)
...

We may either:

  1. Keep max iteration to 10_000, so at least this test runs (in both release and fastdebug modes) which seems to be the goal of 8272973.
  2. Or try to first backport JDK-8312438 which in turn seems to be related to JDK-8263577 with seems to be a significant change 20297a1b

Please let me know preferred way to proceed.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8272973 needs maintainer approval

Issue

  • JDK-8272973: Incorrect compile command used by TestIllegalArrayCopyBeforeInfiniteLoop (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2828/head:pull/2828
$ git checkout pull/2828

Update a local copy of the PR:
$ git checkout pull/2828
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2828/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2828

View PR using the GUI difftool:
$ git pr show -t 2828

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2828.diff

Webrev

Link to Webrev Comment

vieiro avatar Jul 01 '24 08:07 vieiro

:wave: Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 01 '24 08:07 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Jul 01 '24 08:07 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jul 01 '24 08:07 openjdk[bot]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jul 01 '24 08:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 01 '24 08:07 mlbridge[bot]

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 29 '24 13:07 bridgekeeper[bot]

@vieiro This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Aug 26 '24 14:08 bridgekeeper[bot]