jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8334332: TestIOException.java fails if run by root

Open sendaoYan opened this issue 8 months ago • 14 comments

Hi all,

This pull request contains a backport of commit 472b935b from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo.

The reason of backport is not clean is that, multiple PRs have been merged into the jdk17u-dev of this file, including JDK-8215516, JDK-8164597, etc., and these PRs cannot be directly backported to jdk11u-dev.

This PR also change test/langtools/TEST.ROOT, it's partial backport of JDK-8242652. JDK-8242652 can't backport to jdk11u-dev, the jdk11u-dev repo dosen't have file test/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java.

Only change test testcase, the risk is quite very low.

The change verified on below env:

  • [x] linux non-root user
  • [x] linix root user
  • [x] windows

Thanks!


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] JDK-8334332 needs maintainer approval

Issue

  • JDK-8334332: TestIOException.java fails if run by root (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2795/head:pull/2795
$ git checkout pull/2795

Update a local copy of the PR:
$ git checkout pull/2795
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2795/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2795

View PR using the GUI difftool:
$ git pr show -t 2795

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2795.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Jun 18 '24 15:06 sendaoYan