jdk11u-dev
jdk11u-dev copied to clipboard
8331750: [11u] JDK-8259530 is not backported correctly to 11u
This bug fix addresses the issue reported in https://github.com/openjdk/jdk11u-dev/pull/1805#issuecomment-2082702728. I have confirmed that the fix passes the following tests:
- test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java
- All langtool tests
Could someone please review the fix?
Thanks, Kimura Yukihiro
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8331750 needs maintainer approval
Issue
- JDK-8331750: [11u] JDK-8259530 is not backported correctly to 11u (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2702/head:pull/2702
$ git checkout pull/2702
Update a local copy of the PR:
$ git checkout pull/2702
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2702/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2702
View PR using the GUI difftool:
$ git pr show -t 2702
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2702.diff
Webrev
:wave: Welcome back kyukihiro! A progress list of the required criteria for merging this PR into master
will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
⚠️ @yukikimmura This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request I would like to fix the issue. The bug is a careless mistake and does not require complex logic to fix, so there is no risk. I have also thoroughly checked the fix. Testing: All langtool tests.
@yukikimmura 8331750: The approval request has been created successfully.
@yukikimmura As this is a regression in an 11.0.20 backport, would you mind transplanting this PR to the jdk11u repository to get it into 11.0.24? I can take care that review and approval does not take so long this time. Thanks.
I apologize for the inconvenience caused by my bug. I will transplant this PR to 11u.
Thanks, Kimura Yukihiro
Please close this PR and re-apply for approval on https://github.com/openjdk/jdk11u/pull/92.