jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8331790: [11u] Remove problemlist entries after backport of JDK-8228649

Open RealCLanger opened this issue 9 months ago • 3 comments

JDK-8228649 had already been backported to 11.0.5. JDK-8211767 was marked as duplicate of the former but in the hotspot problemlist we still find exclusions referring to it. So it seems we can drop them.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8331790 needs maintainer approval

Issue

  • JDK-8331790: [11u] Remove problemlist entries after backport of JDK-8228649 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2701/head:pull/2701
$ git checkout pull/2701

Update a local copy of the PR:
$ git checkout pull/2701
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2701/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2701

View PR using the GUI difftool:
$ git pr show -t 2701

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2701.diff

Webrev

Link to Webrev Comment

RealCLanger avatar May 07 '24 10:05 RealCLanger

:wave: Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 07 '24 10:05 bridgekeeper[bot]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8331790: [11u] Remove problemlist entries after backport of JDK-8228649

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 665e1cd4f976abf89a32c12a96642cbab2c5d157: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
  • 4c81a1ca3856b76cd851cd236844765db468144c: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
  • 6b225d5a632496431550ebd31379660384fc2eaf: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows
  • b9cb5721c999093aaf8e40677e2bac919dab879e: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 07 '24 10:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 07 '24 10:05 mlbridge[bot]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar May 08 '24 07:05 openjdk[bot]

seems to be okay; but I still see 8211767 in the ProblemList of 17u-dev too so I wonder if it is still relevant there ?

Good observation. I've addressed this here: https://github.com/openjdk/jdk17u-dev/pull/2451

RealCLanger avatar May 08 '24 08:05 RealCLanger

/integrate

RealCLanger avatar May 10 '24 05:05 RealCLanger

Going to push as commit 91fe4e6a39f2e5d3513dde889847ec8c20c4724a. Since your change was applied there have been 4 commits pushed to the master branch:

  • 665e1cd4f976abf89a32c12a96642cbab2c5d157: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
  • 4c81a1ca3856b76cd851cd236844765db468144c: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
  • 6b225d5a632496431550ebd31379660384fc2eaf: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows
  • b9cb5721c999093aaf8e40677e2bac919dab879e: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 10 '24 05:05 openjdk[bot]

@RealCLanger Pushed as commit 91fe4e6a39f2e5d3513dde889847ec8c20c4724a.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 10 '24 05:05 openjdk[bot]