jdk11u-dev icon indicating copy to clipboard operation
jdk11u-dev copied to clipboard

8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar

Open amosshi opened this issue 9 months ago • 7 comments

Backport of JDK-8283349

Testing

  • Local: Test passed
    • AddNodeChangeListener.java: Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies SKIPPED on 2024-05-02
    • Automated jtreg test: jtreg_jdk_tier1
    • java/util/prefs/AddNodeChangeListener.java: SKIPPED[Filter: Keywords - Not matching the given keyword expression: (((!headful)&(!printer)&(!intermittent))) & !manual & !ignore] GitHub 📊 - [0 msec]

Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] JDK-8283349 needs maintainer approval

Issue

  • JDK-8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar (Sub-task - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2695/head:pull/2695
$ git checkout pull/2695

Update a local copy of the PR:
$ git checkout pull/2695
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2695/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2695

View PR using the GUI difftool:
$ git pr show -t 2695

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2695.diff

Webrev

Link to Webrev Comment

amosshi avatar Apr 30 '24 18:04 amosshi

:wave: Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 30 '24 18:04 bridgekeeper[bot]

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b7822c39d323e470ea63289cf72c6a5ec43e6107: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23
  • 3f636f30f9f040a8d320a4be7c2122fb22fd00bf: 8310818: Refactor more Locale tests to use JUnit
  • 1da8fd845cbed721ecc418d44573dd66743b639c: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
  • cabaf7482681fb17cb7722377da6baab0ed2fed3: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Apr 30 '24 18:04 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Apr 30 '24 18:04 openjdk[bot]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Apr 30 '24 18:04 openjdk[bot]

Webrevs

mlbridge[bot] avatar Apr 30 '24 19:04 mlbridge[bot]

/approval request "Backporting for parity with 11.0.24-oracle. Clean backport. No risk, test fix. SAP nightlies SKIPPED on 2024-05-02. Tested passed in local machine MacOS 14.4.1”

amosshi avatar May 06 '24 21:05 amosshi

@amosshi 8283349: The approval request has been created successfully.

openjdk[bot] avatar May 06 '24 21:05 openjdk[bot]

/integrate

amosshi avatar May 08 '24 06:05 amosshi

Going to push as commit 4c81a1ca3856b76cd851cd236844765db468144c. Since your change was applied there have been 8 commits pushed to the master branch:

  • 6b225d5a632496431550ebd31379660384fc2eaf: 8253980: javax/swing/plaf/synth/7158712/bug7158712.java fails on windows
  • b9cb5721c999093aaf8e40677e2bac919dab879e: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • c542dc913a765e9f7ab3ab47d51d5633f8716b9b: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 4202063c1b663cd0ed16209d54b257faf637cd08: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
  • b7822c39d323e470ea63289cf72c6a5ec43e6107: 8331643: [11u]: Bump GHA bootstrap JDK to 11.0.23
  • 3f636f30f9f040a8d320a4be7c2122fb22fd00bf: 8310818: Refactor more Locale tests to use JUnit
  • 1da8fd845cbed721ecc418d44573dd66743b639c: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
  • cabaf7482681fb17cb7722377da6baab0ed2fed3: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 08 '24 06:05 openjdk[bot]

@amosshi Pushed as commit 4c81a1ca3856b76cd851cd236844765db468144c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 08 '24 06:05 openjdk[bot]